Skip to content

#13: Drop the paratest conflict pin (Impex) - #14

Merged
jayjfletcher merged 4 commits into
mainfrom
ring-master/2026-10-28-0130-drop-paratest-conflict-pin
Oct 28, 2026
Merged

jayjfletcher merged 4 commits into
mainfrom
ring-master/2026-10-28-0130-drop-paratest-conflict-pin

Conversation

@jayjfletcher

Copy link
Copy Markdown
Member

Risk: low

What changed

composer.json only: the conflict key (brianium/paratest >=7.26.1) is removed and the pestphp/pest dev constraint is raised from ^5.3.1 to ^5.3.4. No code, config or test changes. composer.lock is gitignored, so it is not part of the diff.

Why

The conflict pin was a temporary workaround for a paratest bug that broke pest --parallel. Pest 5.3.4 pulls in a fixed paratest (7.27.4), so the pin can go. The ^5.3.4 floor is what guarantees the fixed paratest in CI, which resolves dependencies fresh.

Look at

  • composer.json:34: the pestphp/pest floor ^5.3.4; this is the only guard against resolving a broken paratest.
  • composer.json:166: the conflict block is gone and the repositories array now ends the file; check the JSON is still well formed.

Acceptance criteria

  1. No conflict key: the composer.json diff.
  2. pestphp/pest ^5.3.4: composer.json; installed v5.3.4.
  3. Installed pest v5.3.4 and paratest v7.27.4; composer why-not brianium/paratest 7.27.4 reports no blocker.
  4. composer test exits 0 (phpstan 0 errors, pint, type coverage 100%).
  5. composer test runs test:unit (pest --parallel): 363/363 tests passed.
  6. git diff --name-only main...branch lists only composer.json.

Risks

This changes a dev dependency only, with no runtime or consumer impact (Roster and Showroom unaffected). CI resolves dependencies fresh, so transitive versions could differ from the local lock; the ^5.3.4 floor limits that.

Nits: none.

Closes #13

🤖 Generated with Claude Code

jayjfletcher and others added 4 commits October 28, 2026 01:51
…es and verify

Drop the brianium/paratest conflict pin and require pestphp/pest ^5.3.4,
which brings paratest ^7.27.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e composer.json edit in the job worktree

Remove the brianium/paratest conflict pin and require pestphp/pest ^5.3.4,
which brings paratest ^7.27.4 with the parallel fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jayjfletcher
jayjfletcher merged commit 66de976 into main Oct 28, 2026
4 checks passed
@jayjfletcher
jayjfletcher deleted the ring-master/2026-10-28-0130-drop-paratest-conflict-pin branch October 28, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop the paratest conflict pin (Impex)

1 participant