Repository navigation
Register Showroom run link - #17
Merged
jayjfletcher merged 22 commits intoOct 30, 2026
Merged
Conversation
…le, test host and the no-Atrium proof (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le, test host and the no-Atrium proof Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… packages' screens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…wn screens and remove history UI (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-29-2038-register-showroom-run-link
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
src/Atrium/ScreenRegistrations.phpregisters animpex.run-linksection on each screen listed inimpex.atrium.run_link.screens(defaultshowroom.transfers=>row.actions). The view isresources/views/ui/screens/run-link.blade.php.Screen::standard()through the newsrc/Atrium/Screens.php. The controllers and theui/**views render tabs and every standard slot.<x-atrium::audit-trail>andhistoryNavItem()are removed. Incomposer.json, Atrium moves torequire-devandsuggest, and gainsconflict: <0.1.0.ImpexServiceProviderregisters the screens behind the Atrium and UI guards.WithoutAtriumsuite (composer test:without-atrium), awithout-atriumCI job, new arch rule, and docs/CHANGELOG/README/Boost skill updates.Why
Showroom drops its inline run link, so Impex has to own that link and place it on other packages' screens through config only. Impex names no host class. Atrium's history components are being removed (Keen now supplies History), so Impex stops depending on them and treats Atrium as optional. Decisions that shaped it:
conflict.row.actionsfragment.aria-label.Look at
src/Atrium/ScreenRegistrations.php:61and:119: the per-entry register/fail logic, with the environment-dependent throw. Also theshowsRunLinkvisibility chain: record type first, then plugin authorized,ScreenAccess, and route exists.composer.json:48: the newconflicton Atrium (<0.1.0), and therequiretorequire-devandsuggestmove. This one is a public dependency change.config/impex.php: the newatrium.run_link.screenskey. An app that published the config before this change falls back to the shipped default only when the key isnull.src/Atrium/Screens.phpandsrc/Atrium/Http/Controllers/*: the access closure, and the unsaved stand-in rows for flows and channels..github/workflows/tests.ymlandtests/WithoutAtrium/bootstrap.php: the authoritative no-Atrium lane.Tested
The last gate (round-1) passed: phpstan 0 errors, pint passed, pest 476 passed, and the without-atrium suite 6 passed.
ScreenRegistrationsTestandNoShowroomReferenceTest.RunLinkVisibilityTest(each condition false on its own, constant query count).RunLinkSectionTest,TestHostScreenTest,StylesTestandtests/PennantPlus/RunLinkPennantTest.DeclaredScreensTest(all 10 screens),ScreenAccessClosureTestandScreenLayoutTest.NoHistoryUiTestandHistoryNavigationTest.ComposerTest.ArchTest.tests/WithoutAtrium. The CI lane itself is verified only by the workflow run.DocsTest.AuditTrailTestis deleted, andHistoryNavigationTest,tests/Pest.phpandtests/TestCase.phpchange, as criterion 11 expects.Risks
conflictonly works once Atrium's first tag, v0.1.0, includes the registry.run_link.screensentry is skipped with one report, so that link stays missing until someone acts on the report.without-atriumlane cannot be checked locally. It needs to be green on the PR.Merge order
Part of the screen-extensions group (D-009). Merge after Atrium Refactor-Circus/Atrium#16 and Keen Refactor-Circus/Keen#8, together with Showroom Refactor-Circus/Showroom#9 (which removes its inline run link; this PR registers it back into
showroom.transfersrow.actionsfromconfig/impex.php).composer.jsonconflicts withrefactor-circus/atrium<0.1.0.Decisions taken during the build
<0.1.0(suite rule).aria-label(Showroom D-023).Remaining nit
ScreenRegistrations::screens()reads the shipped config file for the default when the key is null; a constant would be more direct.Breaks
The impact stage was not run. Removing
historyNavItem()drops the "Audit log" nav item (ImpexPluginTestupdated); history comes from Keen's wildcard section.composer testre-run green on the final branch: 476 tests plus 6 without-Atrium tests.Spec:
docs/agent/specs/2026-10-29-2038-register-showroom-run-link/🤖 Generated with Claude Code