Repository navigation
Declare screen extensions - #9
Merged
jayjfletcher merged 17 commits intoOct 30, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The without-atrium CI job also removes refactor-circus/cortex, which requires Atrium; ComposerTest checks every dev package requiring Atrium is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Namespace tests/Feature/Ui/ScreenExtensionsTest.php and register its marker component class first: Blade compiles a component name without a backslash as a view, so the global PennantScreenMarker never rendered and every section and tab assertion failed. Drop the double hyphen from the comment in phpunit.without-atrium.xml: XML forbids it, so PHPUnit refused to load the WithoutAtrium suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…screen registry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-29-2038-declare-screen-extensions
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
FeatureFlagController::indexbuilds thepennantplus.featureslist screen, resolves it on Atrium's screen extensions registry after the 403 check, and passesresolvedandrowsto the view.resources/views/atrium/index.blade.phprendersheader.actions, tabs, tab panel,before/afterand arow.actionstrailing cell.src/Atrium/Data/FeatureValueRow.php: an unsaved, read-only Model stand-in for each stored value.PennantPlugin::navigation()), plus their two tests.conflictonrefactor-circus/atriumbelow 0.1.0, atest:without-atriumscript run bycomposer test, aWithoutAtriumsuite (phpunit.without-atrium.xml,tests/WithoutAtrium) and awithout-atriumCI job.standards-feedback.mdfor the arch exclusion.Why
Atrium PR #16 adds a screen extensions registry. PennantPlus declares its flags page there so Keen's History and other packages add tabs and sections without PennantPlus knowing them. Decisions: D-034 (WithoutAtrium suite plus
conflict), D-036/D-040/D-042 (FeatureValueRowwith a named arch exclusion), D-038 (trailing cell only when$managesor sections exist), D-039 (conflict), D-043 (key fromFeatureFlagManager's scope serialization). D-037/D-041 leave the provider move and the arch rule out.Look at
composer.json:41: the newconflict(<0.1.0) is a dependency-contract change. Atrium has no tags yet, so 0.1.0 (the first tag) carries the registry.src/Atrium/Http/Controllers/FeatureFlagController.php:42:resolve()must stay afterabort_unless($manages, 403); the Gate-basedaccessclosure is at line 116.src/Atrium/Data/FeatureValueRow.php: the key encoding (no|collisions) and the throwing persistence methods.resources/views/atrium/index.blade.php: large diff, mostly reindentation. Check the tab/panel replacing the body and the conditional trailing cell..github/workflows/tests.yml:78: thewithout-atriumjob removes Atrium and Cortex and runs with--no-scripts.Tested
Gate round 1 passed:
composer test(phpstan, pint, 162 Pest tests, 7 WithoutAtrium tests),lint:checkand ringside check. Criteria 1, 4, 5, 6 and 7 are covered bytests/Feature/Ui/ScreenExtensionsTest.php; 2 bytests/Unit/FeatureValueRowTest.phpplus that feature test; 3 bytests/ArchTest.php; 8 and 9 bytests/Feature/Ui/ScreenIsolationTest.php; 10 bytests/Feature/ComposerTest.php; 11 bytests/WithoutAtrium/*; 12 bytests/Unit/DocumentationTest.php. The gate mapped criteria to files and did not check individual test names.Risks
conflict <0.1.0may fail installs againstdev-main.authorizeclosure that throws follows Atrium's handling. The README tells registrants not to throw.FeatureValueRowexposes the raw scope identifier to row permission checks.require-devAtrium constraint staysdev-mainuntil the first release, as the spec allows.Notes
conflictwas normalized from<0.2.0to<0.1.0so it matches the rest of the suite. Atrium has no tags yet, and its first tag, v0.1.0, carries the registry.composer testpasses after the change.FeatureFlagController's constructor would break. This is negligible.Breaks
composer.lock. That is environmental and unrelated to this change.Merge order
This must merge as a group with Atrium PR Refactor-Circus/Atrium#16 and the Keen history PR, in that order: Atrium, then Keen, then PennantPlus.
Spec:
docs/agent/specs/2026-10-29-2038-declare-screen-extensions/🤖 Generated with Claude Code