Skip to content

Declare screen extensions - #9

Merged
jayjfletcher merged 17 commits into
mainfrom
ring-master/2026-10-29-2038-declare-screen-extensions
Oct 30, 2026
Merged

jayjfletcher merged 17 commits into
mainfrom
ring-master/2026-10-29-2038-declare-screen-extensions

Conversation

@jayjfletcher

Copy link
Copy Markdown
Member

Risk: high

What changed

  • Controller and view: FeatureFlagController::index builds the pennantplus.features list screen, resolves it on Atrium's screen extensions registry after the 403 check, and passes resolved and rows to the view. resources/views/atrium/index.blade.php renders header.actions, tabs, tab panel, before/after and a row.actions trailing cell.
  • New src/Atrium/Data/FeatureValueRow.php: an unsaved, read-only Model stand-in for each stored value.
  • Removed the inline audit trail and the History nav item (PennantPlugin::navigation()), plus their two tests.
  • Composer and CI: conflict on refactor-circus/atrium below 0.1.0, a test:without-atrium script run by composer test, a WithoutAtrium suite (phpunit.without-atrium.xml, tests/WithoutAtrium) and a without-atrium CI job.
  • Docs: README, Boost skill, AGENTS.md, CHANGELOG, and a row in standards-feedback.md for the arch exclusion.

Why

Atrium PR #16 adds a screen extensions registry. PennantPlus declares its flags page there so Keen's History and other packages add tabs and sections without PennantPlus knowing them. Decisions: D-034 (WithoutAtrium suite plus conflict), D-036/D-040/D-042 (FeatureValueRow with a named arch exclusion), D-038 (trailing cell only when $manages or sections exist), D-039 (conflict), D-043 (key from FeatureFlagManager's scope serialization). D-037/D-041 leave the provider move and the arch rule out.

Look at

  • composer.json:41: the new conflict (<0.1.0) is a dependency-contract change. Atrium has no tags yet, so 0.1.0 (the first tag) carries the registry.
  • src/Atrium/Http/Controllers/FeatureFlagController.php:42: resolve() must stay after abort_unless($manages, 403); the Gate-based access closure is at line 116.
  • src/Atrium/Data/FeatureValueRow.php: the key encoding (no | collisions) and the throwing persistence methods.
  • resources/views/atrium/index.blade.php: large diff, mostly reindentation. Check the tab/panel replacing the body and the conditional trailing cell.
  • .github/workflows/tests.yml:78: the without-atrium job removes Atrium and Cortex and runs with --no-scripts.

Tested

Gate round 1 passed: composer test (phpstan, pint, 162 Pest tests, 7 WithoutAtrium tests), lint:check and ringside check. Criteria 1, 4, 5, 6 and 7 are covered by tests/Feature/Ui/ScreenExtensionsTest.php; 2 by tests/Unit/FeatureValueRowTest.php plus that feature test; 3 by tests/ArchTest.php; 8 and 9 by tests/Feature/Ui/ScreenIsolationTest.php; 10 by tests/Feature/ComposerTest.php; 11 by tests/WithoutAtrium/*; 12 by tests/Unit/DocumentationTest.php. The gate mapped criteria to files and did not check individual test names.

Risks

  • Merge order: this merges only with Atrium PR #16 and Keen, in the order Atrium, Keen, PennantPlus. Before Atrium is released, conflict <0.1.0 may fail installs against dev-main.
  • The flags page administers production flags, and a third-party resolver or authorize closure that throws follows Atrium's handling. The README tells registrants not to throw.
  • FeatureValueRow exposes the raw scope identifier to row permission checks.
  • The CI job drops Cortex too, because Cortex requires Atrium.
  • Open item (nits: 1): the require-dev Atrium constraint stays dev-main until the first release, as the spec allows.

Notes

  • After the factory approved this change, the Atrium conflict was normalized from <0.2.0 to <0.1.0 so it matches the rest of the suite. Atrium has no tags yet, and its first tag, v0.1.0, carries the registry. composer test passes after the change.
  • Nits: one. A subclass that overrides FeatureFlagController's constructor would break. This is negligible.

Breaks

  • None from this change. The impact check failed once in Cortex because its throwaway worktree had no composer.lock. That is environmental and unrelated to this change.

Merge order

This must merge as a group with Atrium PR Refactor-Circus/Atrium#16 and the Keen history PR, in that order: Atrium, then Keen, then PennantPlus.

Spec: docs/agent/specs/2026-10-29-2038-declare-screen-extensions/

🤖 Generated with Claude Code

jayjfletcher and others added 17 commits October 29, 2026 16:41
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The without-atrium CI job also removes refactor-circus/cortex, which requires Atrium; ComposerTest checks every dev package requiring Atrium is removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Namespace tests/Feature/Ui/ScreenExtensionsTest.php and register its marker component class first: Blade compiles a component name without a backslash as a view, so the global PennantScreenMarker never rendered and every section and tab assertion failed.

Drop the double hyphen from the comment in phpunit.without-atrium.xml: XML forbids it, so PHPUnit refused to load the WithoutAtrium suite.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…screen registry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jayjfletcher
jayjfletcher merged commit c09f9e6 into main Oct 30, 2026
6 of 10 checks passed
@jayjfletcher
jayjfletcher deleted the ring-master/2026-10-29-2038-declare-screen-extensions branch November 11, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant