Repository navigation
Declare screen extensions - #8
Merged
jayjfletcher merged 14 commits intoOct 30, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-29-2038-declare-screen-extensions
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
src/Atrium/Support/Screens.phpbuilds the three Atrium pages (polycart.carts,polycart.cart,polycart.types) on Atrium's screen extensions registry, with anaccessclosure that sendspermission()through Polycart'sScreenAccess. Controllers resolve the screen after their ownauthorizeScreen()and passresolvedto the views.Atrium/Data/CartTypeRow, an unsaved stand-in model so cart type rows can takerow.actionssections.PolycartPlugin) are removed.conflictonrefactor-circus/atriumbelow0.1.0, atest:without-atriumscript called fromcomposer test, aWithoutAtriumsuite and awithout-atriumCI job. A new arch rule keeps Atrium classes insidesrc/Atrium.docs/sources-and-history.mdupdated.Why
Atrium PR #16 adds a screen extensions registry, so other packages (Keen's History among them) add tabs and sections without Polycart knowing them. That forces Polycart to declare its screens and drop its own audit trails and History nav item. Decisions that shaped it: D-034 (Atrium stays optional, proven by the WithoutAtrium suite and
conflict), D-036/D-042 (permission()through Polycart'sScreenAccess, operators included), D-037 (CartTypeRow), D-038/D-041 (requireunchanged,conflictadded), D-044/D-045 (ability behaviour in tests).Look at
composer.json:47: theconflictconstraint is<0.1.0, a placeholder (Atrium has no tags yet).src/Atrium/Support/Screens.php:38: the access closure. Check howCartTypeRowand a null record map toCartModel::class.src/Atrium/Data/CartTypeRow.php:1: the final, unsaved model with a string key.resources/views/ui/carts/show.blade.php:1: the largest rewrite. Check header actions, tab panel replacing the body, and theasideslot..github/workflows/tests.yml:1: thewithout-atriumjob andtests/WithoutAtrium/bootstrap.php.Tested
Round 2 gate passed: phpstan 0 errors, pint clean, Pest 297/297, coverage 100%, WithoutAtrium 5/5.
tests/Feature/Ui/ScreenExtensionsTest.php(declaration, slots, access, 403 before extensions run, layout, nothing registered),tests/Unit/CartTypeRowTest.phpand the budget intests/Feature/PerformanceTest.php.ScreenExtensionsTest("leaves no audit trail in any view", "links no history page from its navigation") andtests/Keen/HistoryTest.php.HistoryNavigationTest.phpand two Keen history tests were deleted as the spec lists.tests/Feature/ComposerTest.phpand thetests/ArchTest.phprule.tests/WithoutAtrium/WithoutAtriumTest.php.tests/Feature/Ui/ScreenIsolationTest.php.tests/Feature/DocsTest.php.Risks
dev-main.conflictversion is a placeholder until Atrium's first registry release. Update it when the group merges.conflictand a new CI lane are dependency and CI changes. Check the lane'scomposer remove --devstep on a clean run.row.actionsruns the access closure once per row. The query budget test covers it, but it is the first place to look if pages slow down.Merge order
Part of the screen-extensions group (D-009). Merge after Atrium PR Refactor-Circus/Atrium#16 and Keen PR Refactor-Circus/Keen#8.
composer.jsonconflicts withrefactor-circus/atrium<0.1.0.Breaks
The impact stage was not run for this job. Removing the inline
<x-atrium::audit-trail>andhistoryNavItem()means history on these screens now comes from Keen's wildcard section (Keen #8).composer testre-run green on the final branch before opening this PR.Spec:
docs/agent/specs/2026-10-29-2038-declare-screen-extensions/🤖 Generated with Claude Code