Repository navigation
Conversation
The redistribution routines computed buffer sizes and local memory offsets in Int. With the default 32-bit Int these overflow as soon as one process holds more than 2^31 elements, e.g. when an N x N matrix with N > 46340 is gathered onto a single process, or when the local column offset times LDA exceeds 2^31 (buff2block segfaults).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redistribution routines compute buffer sizes and local memory offsets in Int. With 32-bit Int these overflow once one process holds more than 2^31 elements, e.g. when an N × N matrix with N > 46340 is gathered onto a single process: memoryblocksize() goes negative (xxmr2d:out of memory), hi[h].lstart * mb->lda wraps (SIGSEGV in buff2block), and a single message above 2 GiB aborts the run without any message. Same pattern as #16 fixed in PBLAS.