Bulk Migrate tab: Update CMake buttons + git bulk-update-cmake - #2
Merged
Merged
Conversation
…ate-cmake Runs psxrecomp's tools/update_cmake.py (sibling checkout, else the title's pinned submodule) on each ticked repo and commits CMakeLists.txt only. Honours the Push checkbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Update CMake and Dry run CMake buttons to the PSX Bulk Migrate tab, backed by a new
git bulk-update-cmakecommand in the vendored toolkit.For each ticked title it runs psxrecomp's
tools/update_cmake.py(the sibling psxrecomp checkout's copy if present, else the title's pinnedpsxrecomp/submodule) and commitsCMakeLists.txtonly. The Push checkbox is honoured;--dry-runonly reports. As withbulk-migrate-bundled, no second copy of the logic lives here.Depends on
RetroPortingToolKit/psxrecomp#487 (adds
tools/update_cmake.pyand therecomp-net-headersmanaged block). Without it the command reports "no psxrecomp tools/update_cmake.py" per title.Why
psxrecomp's
main.cppincludesrecomp_net/host_relay.hunconditionally, so offline (PSX_NETPLAY=OFF) title builds fail without recomp-net's include dir on the path. This lets all titles pick up that CMake block in one go.Testing
bulk_update_cmakeagainst a scratch git repo with the sibling psxrecomp checkout: dry run, update + commit (onlyCMakeLists.txt), then "up to date".cli.py/bulkops.pycompile. The ImGui change (studio_main.cpp) mirrors the existingrun_migratelambda but was not built or run here (no display / dependencies).🤖 Generated with Claude Code
https://claude.ai/code/session_01QjC6yeBQEDNWQSVqpKnRJh
Generated by Claude Code