Repository navigation
Conversation
…budgets-test-suite
Wittig18
force-pushed
the
fix-change-password-route
branch
from
October 4, 2026 16:55
3c972c7 to
0434033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #963 - completes the changePassword route implementation and fixes a critical handler bug.
Changes
changePasswordRoute.ts - Fixed inaccurate comment claiming auth was Bearer JWT (or x-user-id stub in dev). Auth is actually Bearer JWT via createRequireAuth (session-hardened). Route paths corrected to actual mounted paths (/me/change-password, /me/password). Full success/failure HTTP contract documented.
changePasswordHandler.ts - Critical bug fix: the handler ignored the service ChangePasswordResult, so wrong passwords/user-not-found/weak passwords returned 200 OK. Now maps each reason to the correct error:
types.ts - Path docs aligned; ChangePasswordResponse updated to real { ok: true, message } shape.
changePasswordRoute.test.ts (new) - 12 supertest tests covering:
All 26 tests pass (handler, service, route suites), lint clean.
Closes #963