Repository navigation
Move apps out of Kernel with new kernel API implementation - #71
Merged
Merged
Conversation
App loader with test app
Move calculator out of kernel
…crease loader slot count
Feat/app files
Move notepad out of kernel
Cleanup branch for merge to main
Rhylanscript
commented
Oct 20, 2026
Rhylanscript
left a comment
Owner
Author
There was a problem hiding this comment.
copilot review:
Assessment
The overall direction is solid, and I don’t see a clear runtime blocker in the loader design itself. The bigger issue is that this PR currently has no automated validation on the head commit: GitHub reports 0 check runs for the PR head, so the new VAPP build/install path is effectively unverified.
One concrete code issue I would fix before merge:
- In
apps/launcher/launcher.c,copy_app()assignsdest->on_prompt_donetwice:dest->on_prompt_done = src->on_prompt_done;dest->on_prompt_done = src->on_prompt_done;
- This is harmless today because it’s a duplicate assignment, but it makes the app-registration copy logic brittle and easy to accidentally overwrite newly added callbacks later (for example
on_open_file/future app hooks). It’s a small but real maintenance bug in the new dynamic app path.
I’d also call out:
- The new app-loader flow is substantial and should have at least one smoke build or CI check before merge, since there are currently no checks configured for this PR head.
- That said, I don’t see an obvious functional blocker in the app registration/loader flow itself beyond the copy routine issue above.
Rhylanscript
commented
Oct 20, 2026
Rhylanscript
left a comment
Owner
Author
There was a problem hiding this comment.
Overall, this is a thoughtful architectural refactor and I don’t see a major functional blocker in the loader design itself.
PR summary:
- Moves Calculator, Files, and Notepad out of the kernel while keeping Terminal builtin.
- Adds a versioned kernel API table (
vigil_api_t) for separately compiled apps. - Introduces a VAPP file format and loader that scans
apps/on the storage disk and registers apps at startup. - Updates the launcher/shell to discover apps and load them on demand.
- Adds Hello as a sample loadable app and updates the build/install flow to package apps onto
dist/storage.img.
Core changes:
- App registration is now dynamic instead of hardcoded in the kernel build.
- The kernel exposes a stable function table to apps so they can call graphics/filesystem services without linking against kernel internals.
- The build now compiles apps separately, emits VAPP files, and installs them onto the storage disk.
Merge readiness:
- Risk: Low-to-medium.
- No obvious runtime blocker in the loader flow, but the new app-loading path is substantial and currently has no visible head-commit validation in the PR checks, so I’d treat this as “needs a green smoke build” before merge.
I’d also keep this as a merge prerequisite:
- Confirm the new app build/install path passes CI or at least a smoke build on the PR head before merging.
- The rest of the diff looks coherent and consistent with the PR’s intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Changed
Documentation