Skip to content

fix(discord): name a forum post from the caption with media (RIG-8690) - #48

Merged
mattwilkinsonn merged 1 commit into
rigel-releasefrom
hermes-sync/rig-8690-name-a-forum-post-from-the-caption-with
Nov 10, 2026
Merged

mattwilkinsonn merged 1 commit into
rigel-releasefrom
hermes-sync/rig-8690-name-a-forum-post-from-the-caption-with

Conversation

@rigel-mintaka

@rigel-mintaka rigel-mintaka commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

A Discord forum send that carries media now names the new post from its caption. Before, the media path sent the text as caption with an empty message, so the post was titled "New Post". This happened to Nemo's #health check-in on 2026-11-08.

Related Issue

RIG-8690 (Linear).

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

  • plugins/platforms/discord/adapter.py _standalone_send: the forum branch derives the thread name from caption or message, the same text it already uses for the starter content.
  • tests/tools/test_discord_send_message_caption.py: forum media send with a caption, and with message text only, both name the post from the first line.

How to Test

  1. The new caption case failed before the fix ('New Post' == 'Health check-in: Sun Nov 8') and passes after.
  2. 61 Discord test files at -j 2: 570 passed, 2 skipped, 0 failed. Ruff clean.

Checklist

Code

  • Conventional Commits
  • Only this fix
  • Regression test fails before and passes after

Documentation & Housekeeping

  • Documentation: N/A

For New Skills

N/A.

Screenshots / Logs

N/A.

Refs RIG-8690

Co-authored-by: Matt Wilkinson matt@rigel.build

Co-authored-by: Matt Wilkinson <matt@rigel.build>
@linear-code

linear-code Bot commented Nov 9, 2026

Copy link
Copy Markdown

RIG-8690

@rigel-mintaka

Copy link
Copy Markdown
Collaborator Author

Review (single pass, trivial diff): one-line fix plus regression test; the forum starter content already used caption or message, the thread name now matches it. Other _derive_forum_thread_name calls have no caption in scope. All-clear on 4cc681a2.

@rigelbuild-bot
rigelbuild-bot marked this pull request as ready for review November 9, 2026 12:20
@rigel-mintaka

Copy link
Copy Markdown
Collaborator Author

Submit rebased onto rigel-release; same two-file diff. All-clear on d6a676a, CI SUCCESS.

@mattwilkinsonn
mattwilkinsonn merged commit 624952c into rigel-release Nov 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants