Skip to content

fix(nix): expect toolchain-built tools in go-analysis check (RIG-8435) - #64

Merged
mattwilkinsonn merged 2 commits into
mainfrom
ci-pipelines/rig-8435-expect-toolchain-built-tools-in-go
Nov 10, 2026
Merged

mattwilkinsonn merged 2 commits into
mainfrom
ci-pipelines/rig-8435-expect-toolchain-built-tools-in-go

Conversation

@rigel-mintaka

@rigel-mintaka rigel-mintaka commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes red main after #58. devenvModules.go builds the tools package with the configured meissa.go.toolchain. The go-analysis flake check compared it against self.packages.<system>.tools, which is built with the default Go. The two derivations differ, so nix flake check threw devenvModules.go must add the analysis tools and shared Go tools.

The check now builds its expected tools package with the same toolchain override the module uses.

It also corrects vendorHash in go/package.nix. The value #58 merged came from a cached goModules output and fails a clean build: specified sha256-CB74…, got sha256-gXUE….

Verification

  • nix flake check -L: all checks passed, including checks.x86_64-linux.go-analysis and checks.x86_64-linux.tools.
  • Failure on main: run 42738240553, step "Check the flake".

Risks

Test-only change in flake.nix checks. No package output changes.

Spec impact

Spec-impact: none

Refs RIG-8435

Co-authored-by: Matt Wilkinson matt@rigel.build

Co-authored-by: Matt Wilkinson <matt@rigel.build>
@linear-code

linear-code Bot commented Nov 10, 2026

Copy link
Copy Markdown

RIG-8435

@rigel-mintaka

Copy link
Copy Markdown
Contributor Author

Review round 1 (head 260ca45): 1 high, 1 low.

  • High, stale vendorHash in go/package.nix: fixed in cb94ecd. A clean goModules build reports got sha256-gXUE…; nix flake check now passes, and the FOD rebuild check passes.
  • Low, the check repeats the module's override expression: kept. The store-path equality is strict; a mutant that drops tools from the module fails the check.

All-clear at head cb94ecd.

@mattwilkinsonn
mattwilkinsonn marked this pull request as ready for review November 10, 2026 02:00
@mattwilkinsonn
mattwilkinsonn merged commit e8fead0 into main Nov 10, 2026
1 check passed
@mattwilkinsonn
mattwilkinsonn deleted the ci-pipelines/rig-8435-expect-toolchain-built-tools-in-go branch November 10, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants