Repository navigation
fix(nix): expect toolchain-built tools in go-analysis check (RIG-8435) - #64
Merged
mattwilkinsonn merged 2 commits intoNov 10, 2026
Merged
mattwilkinsonn merged 2 commits into
mattwilkinsonn merged 2 commits into
Conversation
Co-authored-by: Matt Wilkinson <matt@rigel.build>
Contributor
Author
|
Review round 1 (head 260ca45): 1 high, 1 low.
All-clear at head cb94ecd. |
mattwilkinsonn
marked this pull request as ready for review
November 10, 2026 02:00
mattwilkinsonn
deleted the
ci-pipelines/rig-8435-expect-toolchain-built-tools-in-go
branch
November 10, 2026 02:00
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes red
mainafter #58.devenvModules.gobuilds the tools package with the configuredmeissa.go.toolchain. Thego-analysisflake check compared it againstself.packages.<system>.tools, which is built with the default Go. The two derivations differ, sonix flake checkthrewdevenvModules.go must add the analysis tools and shared Go tools.The check now builds its expected tools package with the same toolchain override the module uses.
It also corrects
vendorHashingo/package.nix. The value #58 merged came from a cached goModules output and fails a clean build:specified sha256-CB74…, got sha256-gXUE….Verification
nix flake check -L: all checks passed, includingchecks.x86_64-linux.go-analysisandchecks.x86_64-linux.tools.Risks
Test-only change in
flake.nixchecks. No package output changes.Spec impact
Spec-impact: none
Refs RIG-8435
Co-authored-by: Matt Wilkinson matt@rigel.build