Skip to content

fix(renovate): classify interrupts by cause and keep restore errors (RIG-8122) - #66

Open
rigel-mintaka wants to merge 5 commits into
mainfrom
go-migration/rig-8122-classify-interrupts-by-cause-and-keep
Open

rigel-mintaka wants to merge 5 commits into
mainfrom
go-migration/rig-8122-classify-interrupts-by-cause-and-keep

Conversation

@rigel-mintaka

@rigel-mintaka rigel-mintaka commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Owner: go-migration. Round-3 review fixes for the M4 refresher (RIG-8122). #63 merged before these landed.

  • refresh relabels an error as interrupted by <signal> only when its chain carries the cancellation (context.Canceled or the SIGINT/SIGTERM cause). A real build failure that races a cancel keeps its own message.
  • When an interrupt also hits a restore failure, both errors are reported; the restore error is no longer dropped.
  • The early-interrupt test now asserts that no write happens, instead of a pin check that was trivially true.
  • renovatehashes_test.go is split into fixture_test.go and interrupt_test.go; every file is under 500 lines.

Verification

  • moon run :ci --force: all 40 tasks pass.
  • go test -race ./internal/renovatehashes/... passes, including the new cases for build failure after cancel and interrupt plus restore failure.
  • golangci-lint (repo config) reports 0 issues; funlen 60/40 and gocognit 20 on the package report 0 issues; gofmt -l is clean.

Risks

  • Error-path and test changes only.

Refs RIG-8122

Co-authored-by: Matt Wilkinson matt@rigel.build

…RIG-8122)

Co-authored-by: Matt Wilkinson <matt@rigel.build>
@linear-code

linear-code Bot commented Nov 10, 2026

Copy link
Copy Markdown

RIG-8122

@rigel-mintaka

Copy link
Copy Markdown
Contributor Author

Review rounds 5-8 (interdiffs from 884c49c): fixed canceled exec child classification (high), stringified cancel sites and double headline (mediums), and added regressions for init/fetch/log/drv-path cancel. Each one was red-checked. Remaining lows are style only (runner name, duplicated test setup), left as is. All-clear on 3710329.

@rigel-mintaka
rigel-mintaka marked this pull request as ready for review November 10, 2026 15:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant