Repository navigation
fix(renovate): classify interrupts by cause and keep restore errors (RIG-8122) - #66
Open
rigel-mintaka wants to merge 5 commits into
Open
rigel-mintaka wants to merge 5 commits into
rigel-mintaka wants to merge 5 commits into
Conversation
…RIG-8122) Co-authored-by: Matt Wilkinson <matt@rigel.build>
…RIG-8122) Co-authored-by: Matt Wilkinson <matt@rigel.build>
…IG-8122) Co-authored-by: Matt Wilkinson <matt@rigel.build>
…122) Co-authored-by: Matt Wilkinson <matt@rigel.build>
Contributor
Author
|
Review rounds 5-8 (interdiffs from 884c49c): fixed canceled exec child classification (high), stringified cancel sites and double headline (mediums), and added regressions for init/fetch/log/drv-path cancel. Each one was red-checked. Remaining lows are style only (runner name, duplicated test setup), left as is. All-clear on 3710329. |
rigel-mintaka
marked this pull request as ready for review
November 10, 2026 15:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owner: go-migration. Round-3 review fixes for the M4 refresher (RIG-8122). #63 merged before these landed.
refreshrelabels an error asinterrupted by <signal>only when its chain carries the cancellation (context.Canceledor the SIGINT/SIGTERM cause). A real build failure that races a cancel keeps its own message.renovatehashes_test.gois split intofixture_test.goandinterrupt_test.go; every file is under 500 lines.Verification
moon run :ci --force: all 40 tasks pass.go test -race ./internal/renovatehashes/...passes, including the new cases for build failure after cancel and interrupt plus restore failure.gofmt -lis clean.Risks
Refs RIG-8122
Co-authored-by: Matt Wilkinson matt@rigel.build