Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "roamjs-components",
"description": "Expansive toolset, utilities, & components for developing RoamJS extensions.",
"version": "0.88.4",
"version": "0.89.0",
"main": "index.js",
"types": "index.d.ts",
"scripts": {
Expand Down
43 changes: 34 additions & 9 deletions src/util/runExtension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,20 @@ type RunReturn =

type RunExtension = (args: OnloadArgs) => Promise<RunReturn>;

const renderLoadFailure = ({
id,
content,
}: {
id: string;
content: string;
}) => {
try {
renderToast({ id, content, intent: "danger" });
} catch (toastError) {
console.error("Failed to display the extension load error.", toastError);
}
};

Comment thread
mdroidian marked this conversation as resolved.
const runExtension = (
run: RunExtension
): { onload: (args: OnloadArgs) => void; onunload: () => void } => {
Expand Down Expand Up @@ -128,14 +142,23 @@ const runExtension = (
})
.catch((e) => {
const error = e as Error;
console.error(`Failed to load ${extensionId} extension.`, error);
Comment thread
mdroidian marked this conversation as resolved.
if (getNodeEnv() === "development") {
renderToast({
renderLoadFailure({
id: "roamjs-extension-error",
content: `Failed to load ${extensionId} extension.`,
intent: "danger",
});
return;
}
let settings: Record<string, unknown> = {};
try {
settings = args.extensionAPI?.settings?.getAll?.() || {};
} catch (settingsError) {
console.error(
"Failed to read extension settings for the error report.",
settingsError
);
}
apiPost({
domain: "https://api.samepage.network",
path: "errors",
Expand All @@ -144,8 +167,8 @@ const runExtension = (
type: "RoamJS Extension Failed to Load",
data: {
extensionId,
settings: args.extensionAPI.settings.getAll(),
roamDepotVersion: args.extension.version,
settings,
roamDepotVersion: args.extension?.version || "unknown",
},
message: error.message,
stack: error.stack,
Expand All @@ -158,17 +181,19 @@ const runExtension = (
},
})
.then(() =>
renderToast({
renderLoadFailure({
id: "roamjs-extension-error",
content: `Failed to load ${extensionId} extension. An Error Report has been sent to the SamePage team.`,
intent: "danger",
})
)
.catch(() => {
renderToast({
.catch((reportError) => {
console.error(
"Failed to send the extension load error report.",
reportError
);
renderLoadFailure({
id: "roamjs-email-error",
content: `Failed to load ${extensionId} extension. The Error Report also failed to send to the SamePage team, please reach out to them directly at support@samepage.network.`,
intent: "danger",
});
});
});
Expand Down
Loading