Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ jobs:
python-version: "3.14"

- name: Install Ruff
# Same floor as requirements_dev.txt.
run: pip install "ruff>=0.16.3"
# Pinned, same as requirements_dev.txt. A new Ruff release can add or
# change rules, so bump it on purpose in its own PR.
run: pip install "ruff==0.17.0"

- name: Ruff check
run: ruff check .
Expand Down
4 changes: 1 addition & 3 deletions custom_components/gree_custom/const.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
"""Constants for the Gree integration."""

from homeassistant.components.climate import (
HVACMode, # pyright: ignore[reportPrivateImportUsage]
)
from homeassistant.components.climate import HVACMode # pyright: ignore[reportPrivateImportUsage]
from homeassistant.const import UnitOfTemperature

from .aiogree.api import (
Expand Down
2 changes: 2 additions & 0 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ Never log an encryption key, cloud password or token in clear text.

`lint.yml` runs `ruff check` and `ruff format --check` on every push and PR.

Ruff is pinned to one exact version, in `lint.yml` and in `requirements_dev.txt`. Keep the two the same. New Ruff releases change rules: 0.16 and 0.17 want opposite forms of the same import, so no code passes both. Bump the pin in its own PR and run `ruff check --fix .` with the new version in that PR.

`validate.yaml` runs three jobs on every push and PR:

- **Hassfest** and **HACS** validation. Neither imports or compiles the Python.
Expand Down
2 changes: 1 addition & 1 deletion requirements_dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Linting / formatting (same tool HA core uses)
ruff>=0.16.3
ruff==0.17.0

# Additional static analysis - HA core's CI also runs these
pylint>=4.0.7
Expand Down
Loading