Repository navigation
1.41.0: Tanks fight a boss and adds that all hit them - #55
Merged
Merged
Conversation
Every target beyond the first in a tank simulation is now a mob that attacks the tank, with an auto attack of 40% of the boss's swing (adjustable under Boss details). Before, extra targets were only things for the tank's own damage to hit, so only the boss ever hurt a tank and Targets 3 or 5 told nothing about survival. The boss is still calibrated alone; the adds are defined beside it and the player moves down the actor list (profileset_main_actor_index follows). SimC's own adds (Hectic Add Cleave, Dungeon Slice) are pets that never attack, so Hectic Add Cleave is off for tanks like Dungeon Slice already was; use Patchwerk, Casting Patchwerk or the movement styles with more targets. Weapon Lab and Trinket Lab keep their single-boss fight. Tested on a Blood DK: 1 target 92.6k damage taken per second and 22% deaths, 5 targets 130.7k and 47%; a tank Upgrade Finder at 3 targets runs its profilesets against the right actor. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every target beyond the first in a tank simulation is now a mob that attacks the tank (40% of a boss swing each, adjustable). The boss is still calibrated alone. Hectic Add Cleave is off for tanks (SimC adds never attack). Weapon Lab and Trinket Lab are unchanged.
Tested: 237 unit tests; real Blood DK compare job (1 vs 5 targets) and a tank Upgrade Finder at 3 targets.
🤖 Generated with Claude Code