Repository navigation
1.44.0: Tank Sim is a page of its own, and tries bags, crests and instance loot - #58
Merged
Merged
Conversation
…tance loot Tank Sim no longer borrows the settings column the other modes share. Its page holds every setting: the fights, fight style, duration, iterations, target error, CPU threads, raid buffs and consumables, the boss, and the gear sources. The shared settings column and buffs panel are hidden in this mode. The gear it can try is now three sources the player switches on or off, merged into one search that ranks on the tank's survival and damage score in each fight: gear from the bags (read from the addon export, with item levels), upgrades with crests (every equipped item at each higher level of its track, within the crests owned), and loot from instances (Upgrade Finder's sources, mounted as a separate copy so Tank Sim's choices never change Upgrade Finder's). Equipped gear stays the baseline. With all three off it runs the fights alone. The job is now mode tank, with the gear search attached, instead of an upgrades job. Tested through the app on a Guardian Druid (bags and instance loot: 121 candidates, a full run with a bag item and raid loot ranked on the tank score) and with unit tests of the merge, the equip limit and the crest fallback. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tank Sim gets its own page with every setting on it (fights, fight style, duration, iterations, target error, CPU threads, buffs and consumables, boss, gear sources). The shared settings column is hidden in this mode.
Gear it can try, each source switched on or off and merged into one search ranked on the tank score:
Tested:
npm test(243 pass), newtests/tankgear.test.mjs, andtests/tank-gear-integration.mjsrun against a live server with a Guardian Druid.🤖 Generated with Claude Code