Repository navigation
fix(platform): make the PR-data marker readable on touch and keyboard - #293
Merged
cpenaforte-clickbus merged 9 commits intoOct 8, 2026
Merged
cpenaforte-clickbus merged 9 commits into
cpenaforte-clickbus merged 9 commits into
Conversation
The amber dot is the only per-row cue on the compare page, and amber-500 sits near 2.1:1 on the light card, below the 3:1 WCAG 1.4.11 asks of it. The dot and its legend now use amber-600 on light (about 3.2:1) and keep amber-500 on dark (well above 3:1). The PR-data tooltip said merge strategy isn't classified "when enrichment fails"; the engine only skips it when enrichment fails for merged PRs, so the copy now says so, in both locales. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The failed PR-read steps lived only in a hover title and screen-reader text, on the compare dot and on the repo-page badge, so touch and keyboard users could see that the read was incomplete but not where. The mobile compare card now shows the localized steps as muted text next to the dot, and the repo page shows them next to the badge. On the card the visible steps replace the dot's sr-only sentence, so screen readers read them once, after a short sr-only "PR data incomplete:" prefix. The card marker also drops its ml-2: the row already spaces its items with gap-2. The desktop table is unchanged. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason for the `as unknown as` cast in getOrgReposSummary sat two lines above the query, away from the cast it explains. The query result is now bound first and the cast returned on its own line, with the reason right above it. No behavior change. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renders the compare view with one degraded and one clean repo and checks what the last fixes changed: the mobile card shows the failed steps as text after an sr-only prefix, the full sentence stays screen-reader text only in the table, the card marker has no margin, and the dot is amber-600 with amber-500 only on dark. All four fail against the previous marker. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed open list, or a failed enrichment or reviews pass for open PRs, leaves open-PR fields out of the run, and the engine's report caveat now says so. The tooltip on the PR-data badge and marker listed only flow, review and in-PR metrics; it now names open-PR metrics too, in both locales. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed merged list omits the PR lifecycle fields (counts, time to merge, cycle time), and a partial read skews them. The engine's report caveat now says so; the PR-data tooltip mirrors it in both locales. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The repo-page badge now has the failed steps as visible text beside it, yet kept a title with the same steps in a sentence. Screen readers may read a title as a description, so the steps could be announced twice. The title goes; the visible text carries the steps. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The desktop compare table kept the failed PR-read steps in a hover title and screen-reader text only, so sighted keyboard users could not see them, and on the mobile card the steps sat inline with the truncating repo name, where a long list squeezed it. Both layouts now put the amber dot and the localized steps on a line of their own under the repo name. The dot and the steps are aria-hidden, carrying the full sentence as their hover title, and screen readers read that sentence once as sr-only text, in both layouts alike (the card's short sr-only prefix gives way to it). Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks done
The label for the `fetch` step read "PR read" / "leitura de PRs", so the step sentence said "This run's PR read failed at: PR read." It now says "entire read" / "leitura inteira". Found in a manual end-to-end check. Refs #236 Assisted-by: Claude Code <noreply@anthropic.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 8, 2026
cpenaforte-clickbus
merged commit Oct 8, 2026
4628df7
into
fix/pr-data-incomplete-polish
4 checks passed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto e Motivação
A revisão final das correções de plataforma (#292) apontou o que ainda dependia de passar o mouse: quem usa toque ou teclado não via quais passos da leitura falharam, nem na comparação nem no badge da página do repositório, porque essa informação estava só no
title. O ponto âmbar tinha contraste de cerca de 2,2:1 sobre fundo claro, abaixo dos 3:1 do WCAG 1.4.11 para o único indicador da linha. E o tooltip dizia que a merge strategy não é classificada quando o enriquecimento falha, o que, com a degradação por estado do engine, só vale para os PRs mergeados.Refs #236
Mudanças
titleque repetia os passos.bg-amber-600no tema claro, que dá cerca de 3,2:1 sobre o card, com variante escura própria; o card do celular perde um espaçamento dobrado.fetchpassa a "leitura inteira" / "entire read": antes a frase dizia "A leitura de PRs desta execução falhou em: leitura de PRs" — achado numa verificação manual de ponta a ponta.Plano de Teste
npx vitest run— inclusive o teste de renderização da comparação: passos visíveis nos dois layouts, uma única frase para leitor de tela por layout, passos fora da linha do nome no celular — rodado em8e83ca4: 431 passednpm run lint,npx tsc --noEmit,npm run test:coverage,npm run build— os passos do jobplatformdo CI — rodado em4911e6d: lint 0 erros,tscok,test:coverage431 passed, build ok; depois da correção do rótulo, em8e83ca4: vitest 431,tsce lint de novo, e o CI verde4911e6d, com o rótulo corrigido conferido depois em8e83ca4: plataforma rodando sobre as migrações reais e um PostgREST, com payloads do engine em sete cenários de falha, no Playwright em desktop, celular (390 px), só teclado, leitor de tela, tema escuro, pt-BR, en-US e es-ES; os passos ficam visíveis sem mouse, o leitor de tela ouve uma frase por linha e o rótulo corrigido defetch("leitura inteira") foi conferido no navegadorA verificação roda fora da máquina de quem construiu: o job
platformdo CI (RFC 0029, PM-4).Impacto e Risco
title, contraste de pelo menos 3:1 e uma única leitura por layout no leitor de tela.Tamanho (RFC 0028 §2.4): 247 linhas, faixa 51–250.
Plano de Rollback
git revertdo merge. Volta o comportamento do #292; nada a migrar.Referências
Autoria Assistida
🤖 Generated with Claude Code