feat: add Korean (ko) translation - #148
Merged
Merged
Conversation
Owner
|
Hi, I highly appreciate your effort! It looks nice and I will be adding that for the next version that would be released within this month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Korean (ko) translation PR body template
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.
Changes
locales/ko.json(new file, 502/502 keys — full parity withlocales/en.json, identical key order, no missing/extra keys)locales/README.md:ko.jsontolocales/'ko'tolanguageList[]and'한국어'tolanguageNameList[]insupporter.js'ko'tolanguageCodeList[]inmain.js'ko-KR'(NSIS/electron-builder culture code, matching the existingzh-CN/zh-TWconvention) tonsis.installerLanguages[]inres/builder/nsis.jsTwo other files reference
zh-CN/zh-TWbut were intentionally left untouched as they are outside the scope of thelocales/README.mdguide:update.json— per-release announcement text (would require translating historical release notes rather than the app UI)res/builder/output/nsis.js— a separate, unused build config (package.json'snsisscript points atres/builder/nsis.js, not this file); it also predates and lacks thearm64support already present inres/builder/nsis.jsTesting
locales/ko.jsonwith bothpython -c "import json"andnode -e "JSON.parse(...)"— no syntax errorslocales/en.json: 502/502 keys present, identical key order, 0 missing/extra\rline-break escapes and%-style placeholders are preserved correctly in all translated stringsnode --checkon all 3 edited JS files (main.js,supporter.js,res/builder/nsis.js) — all pass (no lint/test scripts exist in this repo)