Skip to content

feat(now): open the session action sheet on long-press of external and history cards - #1573

Merged
RonenMars merged 2 commits into
mainfrom
feat/long-press-actions
Nov 18, 2026
Merged

RonenMars merged 2 commits into
mainfrom
feat/long-press-actions

Conversation

@RonenMars

Copy link
Copy Markdown
Owner

Summary

long-press on a Now card
  managed session  -> SessionActionSheet (unchanged, End session group while the PTY is live)
  external session -> SessionActionSheet, reduced
       Open, Copy ID, Rename, Favorite
       Terminate only while its process is alive
  history conversation -> SessionActionSheet (was QuickAccessActionSheet)
       Open, Copy ID, Favorite

Evidence

  • Before: long-pressing an external card did nothing, and a history card opened the quick-access sheet.
    After: both open the session action sheet, covered by three new NowList integration tests.
long press
  opens a reduced sheet on an alive external card: no managed End actions, Terminate offered
  offers no Terminate on an external row whose process is gone
  copies the id from a history conversation sheet

Local run on the rebased branch: NowList suite 26 passed, tsc 0 errors, ESLint clean.

Merge Danger

Door: two-way

Blast Radius: Now tab card actions

… add copy id to conversations

An external session card did nothing on long-press.
It now opens a reduced sheet: Open, Copy ID, Rename, Favorite, and Terminate while its process is alive.
The managed End-session actions stay off external sessions.
A history conversation sheet gains Copy ID.
@RonenMars
RonenMars merged commit f5d8075 into main Nov 18, 2026
24 checks passed
@RonenMars
RonenMars deleted the feat/long-press-actions branch November 18, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant