Remove extraneous dbg! expression - #318
Open
kitlith wants to merge 2 commits into
Open
Conversation
This fixes building for release
The failure when building for release slipped by CI because CI is only building the debug profile, and not the release profile. Fix that by at least running a cargo check against the release profile.
Author
|
We can change around exactly how we're doing a check against the release profile in CI, but I feel like something similar should be implemented if you want to keep conditionally enabling the Debug derive, to be able to catch future mistakes like this in CI before a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes building for release