Repository navigation
Conversation
… AffinePoint The reference Add impls between EdwardsPoint and AffinePoint dereferenced both sides and called the by-value impl, which the define_add_variants macro forwards back to the reference impl, so the addition never returned. Convert the affine point with to_edwards() instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an
EdwardsPointand anAffinePointwith+never returns. The reference impls dereference both sides and call the by-value impl, anddefine_add_variants!forwards the by-value impl back to the reference one, so they call each other forever.+=and-were fine because they go throughto_edwards().Both reference impls now convert the affine point with
to_edwards(), likeSubandAddAssignalready do.add_affine_pointcovers all four by-value and by-reference combinations; on master it hangs.