Repository navigation
Rename room - #3571
Open
tevanburen wants to merge 68 commits into
Open
Rename room#3571tevanburen wants to merge 68 commits into
tevanburen wants to merge 68 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts: # packages/playground/src/components/common/global-nav.tsx # packages/playground/src/components/common/index.ts # packages/playground/src/pages/main-layout.tsx # packages/playground/src/stores/chat/chat.store.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with SEMOSS/Semoss#2915
Description
New rooms only ever got a placeholder name (the first 15 characters of the prompt), with nothing to replace it. This consumes a generated room name from the backend — delivered as a stream chunk during chat and as a snapshot field during agent runs — and reveals it in the breadcrumb with a typewriter effect instead of a jarring pop-in.
Changes Made
libs/sdk: added aroom_namestream-chunk type and aroomNamefield onAgentRunSnapshot.response-message.store.ts: applies aroom_namechunk to the room's metadata as it streams in, with a fallback check on the completed result.agent-harness.ts: appliessnapshot.roomNamefrom both the live polling and terminal snapshot callbacks.typewriter-text.tsx(new) /main-layout.tsx: the page-title breadcrumb reveals its text character-by-character whenever it changes, used for the placeholder → generated-name swap.How to Test