Skip to content

OB-054: Build a meaningful spread and reference-price row #706

Closed

Description

@IbrahimIjai

Priority: P1 · Size: S · Area: order-book-ui · Depends on: OB-019, OB-046, OB-051

Motion skills: Agents and developers must use .agents/skills/animate/SKILL.md and .agents/skills/review-animations/SKILL.md, following the required workflow below.

Scope: Show spread in quote units and percentage, with last trade or mark
price explicitly identified. Use the agreed policy when either side is absent
or the book revision is invalid.

Acceptance criteria:

  • Fixtures verify the spread denominator, precision, and labels; unavailable calculations render an explanation instead of NaN or zero.
  • Price direction emphasis is restrained, values remain immediately readable, and oracle/mark data is never labeled as a fill.

Season context

Build a standard order book trading experience for SO4 on Stellar: a compact watchlist and market header, a large chart, an adjacent order book/recent-trades panel, a right-hand order ticket, and account tables below. Preserve SO4's brand and shared design tokens. Keep verified perpetuals capabilities; do not add Pro mode, EVM wallet connection, new margin modes, TWAP, or spot/perps transfers solely to imitate the reference layout.

An order book layout does not establish an executable order book. Matching, resting depth, partial fills, signing, and settlement need verified sources; account orders, oracle prices, pool liquidity, and illustrative data are not substitutes for executable depth. Preserve geometry during loading and live updates. Motion should clarify state changes, with reduced-motion, focus, touch, and interruption behavior included.

Extend the existing custom @workspace/ui/components/toast implementation; do not install Sonner or a second toaster. Use TanStack Query for scoped caching, targeted refresh, and explicit indexer catch-up after confirmed transactions.

Common completion rules

  • Follow AGENTS.md, including reproduction and regression
    coverage for bug fixes, the full ordered commit gate, and integration checks for
    web/indexer changes. Do not weaken checks. Dependency/build changes require the
    clean-room verification specified there.
  • Use existing components and named design tokens from
    packages/ui. Token changes include the corresponding
    DESIGN.md documentation. No parallel theme or toast system.
  • Use explicit MSW handlers for network tests. Include relevant success, empty,
    stale, and failure behavior; keep timers and streams deterministic. Visual work
    includes desktop/mobile and reduced-motion review, with relevant theme coverage.
  • Include a user-visible changelog entry when required by the repository's
    entry format. Documentation changes
    follow apps/docs/CONTRIBUTING.md.
  • Distinguish wallet approval, submission, ledger confirmation, order acceptance,
    execution/partial fill, and indexer catch-up. A transaction confirmation must
    never falsely imply that a resting order has filled.
  • Use targeted invalidation after confirmed changes, and explicitly handle
    inactive queries when their views next open. Invalidating an active query marks
    it stale and triggers background refetch; it does not prove an indexer has
    caught up. See TanStack Query invalidation.
  • Cache freshness and retention are separate choices. Define them by data class,
    rather than treating a long staleTime as a real-time strategy. See
    TanStack Query defaults.
  • Measure speed on the baseline device/network profile in OB-010. Initial field
    targets are p75 LCP ≤ 2.5 s, INP ≤ 200 ms, and CLS ≤ 0.1, reported separately
    for landing and trading and for mobile/desktop. Lab results are diagnostics,
    not a substitute for field percentiles. See Web Vitals.

Required animation skills for agents and developers

The named skill files exist in the maintainer’s local checkout but are not yet available on the published main branch. Obtain them from the maintainer if your checkout lacks them before implementing motion. The required workflow is reproduced below so this issue is self-contained.

This issue requires both coding agents and human developers to follow the repository's Emil Kowalski-based guidance:

  1. Read .agents/skills/animate/SKILL.md before designing
    or implementing motion. Decide whether the interaction should animate, state its
    purpose, reuse existing tokens, and choose the smallest suitable implementation.
    Use the relevant .agents/skills/animate/RECIPES.md, adapting
    examples to the existing components and approved motion budget.
  2. Apply .agents/skills/review-animations/SKILL.md
    before review. Consult its .agents/skills/review-animations/STANDARDS.md
    for precise timing/easing guidance. Agents explicitly load the skills; developers
    use the same files as implementation and review checklists.
  3. Attach the motion purpose, token/property choices, normal/reduced-motion clips,
    and rapid-interruption evidence to the PR. Include the review's findings table
    and verdict; address blocking findings before marking the issue complete.

These requirements are part of this issue's acceptance criteria. A generic
fade on every element is not sufficient. Prefer restrained feedback in trading,
stable readable values, trigger-aware overlays, and richer but inexpensive landing
motion. Skills guide the craft; the user's requirement to reuse packages/ui
components and its existing toast remains authoritative. Do not replace that toast
with Sonner or another library to follow a recipe.

Priority key: P0 = prerequisite/correctness; P1 = core experience; P2 = later polish. Size: S/M/L describes relative scope, not a delivery-time promise.

Activity

  1. I-Am-Finite commented on Sep 26, 2026

    @I-Am-Finite

    @I-Am-Finite has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hi! I've reviewed the issue and requirements for oB-054: Build a meaningful spread and reference-price row. I can configure this cleanly following your existing workspace conventions with zero extraneous dependencies. Ready to submit a well-tested PR within a few hours once assigned.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @I-Am-Finite to this issue.

  2. balisdev commented on Sep 26, 2026

    @balisdev
    Contributor

    @balisdev has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    I can work on this issue please assign it to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @balisdev to this issue.

  3. drips-wave commented on Sep 26, 2026

    @drips-wave

    Congratulations, @balisdev! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @balisdev: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. grantfox-oss commented on Sep 27, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @balisdev's PR #820 was approved and merged by @IbrahimIjai.

    🏆 @balisdev: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,108 total points). Track your full progress on GrantFox.

    👏 Great work, @balisdev! Keep contributing to SO4-Markets.

  5. drips-wave commented on Sep 27, 2026

    @drips-wave

    This issue has been completed by @balisdev as part of the Stellar Wave Program's 9th Wave 🥳

    😎 @balisdev: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  6. added a commit that references this issue on Sep 27, 2026
    eda1b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions