Repository navigation
Conversation
fetchOracleCandles falls back to the GMX API (ENV.ORACLE_URL) but labelled the series "SO4 Oracle Reference". With the third-party SO4 oracle worker removed, that label misattributes third-party GMX (Arbitrum) prices to SO4. Rename all three GMX-path return sites (aborted early-return, success return, catch fallback) to "GMX Oracle Reference". Refs SO4-Markets#830
|
@Mohit0628 is attempting to deploy a commit to the Ijai's projects Team on Vercel. A member of the Team first needs to authorize it. |
Follow the changelog convention of using the pull request number in the filename and frontmatter (was the issue number 830).
|
Quality gate run locally (Windows) — full results Ran the entire gate from the repo root on
The two failures are pre-existing and in files this PR does not touch. This change edits three string literals in
Happy to open a separate PR for these if that's useful — keeping this one scoped to the label fix. |
|
Disclosure: this contribution was made with the help of Sarvam.ai assistant, it helped the find the issue after which codes and tests were run full gate locally myself. |
What changed and why
fetchOracleCandlesinapps/web/src/features/trade/lib/oracle.tsfalls back to the GMX API (ENV.ORACLE_URL) but labelled the resulting series"SO4 Oracle Reference". Now that the third-party SO4 oracle worker has been removed, that label misattributes third-party GMX (Arbitrum) prices to SO4. This renames all three GMX-path return sites to"GMX Oracle Reference":venueName,catchfallback.No logic, types, or pricing maths changed — it is a display-label correction. The
source: "gmx"value was already correct.A changelog entry is included at
.changelog/unreleased/978-gmx-oracle-label.md(type: fixed,area: trade).Verification
Full gate run locally (Windows), from the repo root:
bun install --frozen-lockfilebun run check:tokensbun run check:contentbun run testbun run test:coveragebun run buildbun lint— fails on 9 pre-existing errors (see comment below)bun typecheck— fails on 2 pre-existing errors (see comment below)The two failing checks fail only on errors in files this PR does not modify; the full list is in the comment below. Everything else is green.
Linked issue
Closes #830