Repository navigation
outbound: default composeFiles to the config layer's compose sources; release 0.14.0 - #133
Merged
Merged
Conversation
An outbound target with `service` and no `composeFiles` looked the service up in every compose file in the repository, so a local-dev compose with the same service name could make a key read as set by the deploy, as #126 fixed for appsettings sources. The check command now passes the globs of the enabled config layer's `compose` sources to every layer, and outbound uses them as the default; every compose file remains the default only without such a source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QszGCmzG1kAQaxaBvaTEyR
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QszGCmzG1kAQaxaBvaTEyR
jarmatys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #127 (same trap as #126): an
outboundtarget withserviceand nocomposeFileslooked the service up in every compose file in the repository, so a local-dev compose with the same service name could make a key read as set by the deploy.checkpasses the globs of the enabledconfiglayer'scomposesources to every layer (LayerContext.deployComposeFiles).outbound.targets[].composeFilesnow defaults to those globs; every compose file remains the default only without aconfigcompose source. An explicitcomposeFilesstill wins.Tests
test/e2e/outbound-deploy-keys.test.ts: a local-dev compose that sets the key no longer turns the target into the key (fails without the change), and the fallback without a config compose source.vitest run: 1364 passed, 24 skipped;tsc --noEmitandbiome check .clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01QszGCmzG1kAQaxaBvaTEyR
Generated by Claude Code