Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_compile_features(SQLiteCpp PUBLIC cxx_std_17)CMake baseline rationale
CMake 3.8 would be sufficient to express C++17, and CMake 3.12 is the first release that understands
CXX_STANDARD 20. This PR uses CMake 3.13 because it still supports C++20 configuration while also matching the minimum required by the bundled GoogleTest 1.16 project when tests fall back to the submodule.This keeps the baseline conservative while making the declared project minimum consistent with its bundled test dependency.
Standard compatibility coverage
The CMake consumer workflow now tests:
This checks the required minimum, a newer-standard consumer against the minimum-standard library, and compilation of the library itself as C++20.
Scope
This PR only establishes the new language/build baseline and starts the 4.0.0 development line. It deliberately does not re-introduce the ABI-breaking changes reverted before 3.4.0; those can follow in a separate PR after this one is merged.