Repository navigation
Enable Kirshara queue protections on macOS - #339
Merged
Merged
Conversation
netniV
requested changes
Oct 24, 2026
| #include <Windows.h> | ||
| // Use the host ABI for the 24-byte value-type callback on Windows and both Mac architectures. | ||
| // Validate the managed layout before installing. | ||
| #if (defined(_WIN32) && defined(_M_X64)) || (defined(__APPLE__) && (defined(__arm64__) || defined(__x86_64__))) |
Collaborator
There was a problem hiding this comment.
This seems redundant considering this is the platforms we cover?
Contributor
Author
There was a problem hiding this comment.
Removed this guard and the empty fallback in 9228894. The implementation now builds directly on our supported platforms; runtime layout and method checks are unchanged.
| // Windows x64 callback ABI is validated against running metadata; current native fit is recorded separately. | ||
| #if defined(_WIN32) && defined(_M_X64) | ||
| // Shared 64-bit managed layout; incompatible runtime contracts leave the feature unavailable. | ||
| #if (defined(_WIN32) && defined(_M_X64)) || (defined(__APPLE__) && (defined(__arm64__) || defined(__x86_64__))) |
Contributor
Author
There was a problem hiding this comment.
Removed this guard and its no-op fallback in 9228894 as well, retaining the existing runtime validation.
netniV
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faster Queue Recovery and Thin Queue Protection currently compile to no-ops on macOS. Enable their existing implementations on Apple Silicon and Intel, using the host ABI for the validated course-response aggregate. Queue Address Guard already supports macOS. Queue policy, settings, defaults and hook ownership are unchanged.
This is a standalone change from
dev; it does not depend on settings PR #333. Includes focused startup, cross-fleet queue, recall, destroyed-head and off/on tester instructions.Validation: three independent semantic reviews, Windows release build, all three queue-policy suites, diff and upstream scope guards pass. Historical Mac client 199 inspection supports the aggregate ABI and all seven detour extents on both architectures. Current Mac architecture builds, current-client native fit and exact-artifact gameplay remain pending; historical evidence does not qualify a newer client.
Includes the portable fleet-sync number conversion from #354 as a build dependency, avoiding a macOS 26 requirement in the shared sync source.