Repository navigation
댓글·답글 입력 버튼을 Figma 디자인에 맞춤 - #50
Conversation
빈 입력에서도 댓글과 답글의 전송 버튼 배경을 디자인 토큰의 기본 갈색으로 표시한다. 제출 중에는 비활성 토큰을 사용하고 눌림 피드백을 유지한다.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
전반적으로 PR은 Figma 디자인 요구사항과 기존 아키텍처, 코딩 컨벤션을 잘 준수하고 있습니다. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02233303f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private struct CompactSendButtonStyle: ButtonStyle { | ||
| func makeBody(configuration: Configuration) -> some View { | ||
| configuration.label | ||
| .opacity(configuration.isPressed ? 0.7 : 1) |
There was a problem hiding this comment.
When the user holds the compact send button, this style fades the entire label—including its icon and background—rather than rendering the designated pressed background. That produces a translucent, off-spec state and directly violates the repository requirement that pressed feedback use the component's Background.pressed token instead of opacity; add/use the appropriate icon-button pressed token here.
AGENTS.md reference: AGENTS.md:L958-L958
Useful? React with 👍 / 👎.
| .frame(width: 40, height: 40) | ||
| .background( | ||
| isSendEnabled ? .buttonIconBackgroundDefault : .buttonIconBackgroundDisabled, | ||
| isSubmitting ? .buttonIconBackgroundDisabled : .buttonIconBackgroundDefault, |
There was a problem hiding this comment.
While a reply create/update request is in flight, CommentReplyFeature immediately clears replyText, making the button disabled, but CommentReplyView does not pass this new flag and therefore retains the default isSubmitting == false. This branch consequently paints the disabled reply button with the dark default background for the whole request, whereas the comment composer receives the intended disabled submission color; track and pass the reply submission state as well.
Useful? React with 👍 / 👎.
1 participant
빈 댓글·답글 입력에서도 Figma처럼 진한 갈색 전송 원형을 표시합니다. 기존
PickeCommentInputBar와 디자인 토큰을 재사용하며, 빈 입력은 계속 전송할 수 없고 제출 중에는 비활성 색상을 사용합니다. 버튼을 누를 때의 시각적 피드백도 유지합니다.검증: iPhone 18 Pro 시뮬레이터 캡처 테스트 1건, 댓글·답글 상호작용 테스트 2건 통과. Figma 댓글·답글 원본 캡처와 전송 버튼을 대조했고 Claude 코드 점검에서 결함이 보고되지 않았습니다.