feat(media): navigate attachment bundles and galleries in the viewer - #1968
Open
Th-Underscore wants to merge 1 commit into
Open
feat(media): navigate attachment bundles and galleries in the viewer#1968Th-Underscore wants to merge 1 commit into
Th-Underscore wants to merge 1 commit into
Conversation
Th-Underscore
force-pushed
the
feat/media-viewer-navigation
branch
from
August 27, 2026 03:14
0cdbfdc to
95f188a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The zoom-in media viewer gains prev/next navigation on desktop:
button:hoverlift, which previously caused an infinite hover-bounce where the hitbox chased the cursor.Staged composer attachments: clicking a staged image preview opens the same viewer for all staged images as their own local bundle - newest-first matching the tile strip, wrap-around, edge-dimmed buttons. Save works directly from the local
File(no download round-trip); removing attachments while open closes cleanly; non-image attachments don't open the viewer.Tested on the desktop app, Ubuntu 24.04.
Type of change
Checklist:
.changesetAI disclosure:
I designed and directed the feature and tested it in the GUI; the code itself was AI-generated.
Bundle membership reuses the timeline collapse predicate (same sender + media type + time window) over the rendered processed rows (
mediaBundle.tspure helpers) rather than raw event arrays, as raw arrays interleave non-media rows, which broke naive adjacency. Gallery items come from the gallery content's item list in one pass. Navigation arithmetic is shared via a smallwrapIndexhelper in$utils/common; keyboard handling ignores events while inputs/buttons/menu items hold focus. Preloading resolves each neighbour through Sable's normal media pipeline so encryption keys register and the loopback cache warms exactly as if it had been displayed.