fix(shortcuts): make the global show/hide window shortcut opt-in and configurable - #1972
Open
Th-Underscore wants to merge 1 commit into
Open
fix(shortcuts): make the global show/hide window shortcut opt-in and configurable#1972Th-Underscore wants to merge 1 commit into
Th-Underscore wants to merge 1 commit into
Conversation
Th-Underscore
marked this pull request as ready for review
August 27, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1971.
Description
Sable currently registers
Ctrl+Shift+Sas a system-wide show/hide hotkey on startup, unconditionally and non-configurably - hijacking the key from every other application (it collides with "Save As" in most of them). This makes the shortcut:Show/Hide Sableentry in Settings -> Keyboard Shortcuts. Assigning a binding registers it with the OS first - a binding the OS rejects is never persisted - and clearing it (Backspace/Delete) unregisters immediately. Changes apply live; startup re-registers whatever was saved.set_global_window_shortcutTauri command persists to the desktop settings store and re-registers,menu.rsreads the binding from the store on boot, and atoTauriAcceleratorconverter maps captured web bindings to Tauri accelerator strings.Tested on the desktop app, Ubuntu 24.04, as well as Windows 11 when I first built this a couple weeks ago.
One thought that's deliberately out of scope for this PR: since the shortcut is now off by default, new users have no natural way to discover it. It may be worth a one-time notification or a hint somewhere pointing at Settings -> Keyboard Shortcuts, so the feature doesn't become invisible to everyone who'd actually want it.
Type of change
Checklist:
.changesetAI disclosure
I hit this bug myself and tested the builds; the code was AI-generated. The Rust side stores the binding under the existing desktop-settings store (
globalWindowShortcutkey),register_global_shortcutstreats missing/null/empty as unregistered, and the command unregisters-all then re-registers the new binding. The frontend adds the shortcut definition with anulldefault, the capture flow routes through the command before persisting, and an effect keeps the OS registration in sync with the persisted value.