Skip to content

fix(dbng): allow database-destroy by name - #1278

Open
WilliamK112 wants to merge 2 commits into
Scalingo:masterfrom
WilliamK112:fix/database-destroy-name-1273
Open

WilliamK112 wants to merge 2 commits into
Scalingo:masterfrom
WilliamK112:fix/database-destroy-name-1273

Conversation

@WilliamK112

Copy link
Copy Markdown
Contributor

Summary

  • resolve database-destroy targets by either exact database ID or name
  • pass the resolved ID to the preview destroy API so name-based input follows the existing deletion path
  • update command help and add regression coverage for ID, name, and missing targets

Closes #1273

Validation

  • go test ./...

  • go test -race ./dbng

  • go vet ./...

  • git diff --check

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

AI assistance

Codex assisted with drafting the focused implementation and tests. I reviewed the diff and verified it with the full Go test suite, race detection for the affected package, and go vet.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T23:01:20.404905Z 5cbc2b2 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@WilliamK112

Copy link
Copy Markdown
Contributor Author

@codex review

@WilliamK112
WilliamK112 force-pushed the fix/database-destroy-name-1273 branch from 5cbc2b2 to 596e9ae Compare October 30, 2026 15:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[database-destroy] Impossible to destroy a database that failed to start

1 participant