Repository navigation
Remove MatrixScan Find leftovers from the MatrixScan Pick guides - #492
Merged
Merged
Conversation
The Pick get-started guides were copied from Find and kept its wording and, on .NET iOS, its API: - "finish the find session" now says "pick session", and the Flutter comments say "scanning", not "finding". - The .NET sample page is PickBarcodePage everywhere (it was two different Find names, so the snippets didn't fit together). - .NET iOS called BarcodePickView.PrepareSearching() and StopSearching(), which BarcodePickView doesn't have (they are BarcodeFindView methods). It now calls Start() and Stop(), as the API reference and the public .NET Pick samples do, and the prose matches the code. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
moritzhartmeier
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MatrixScan Pick get-started guides were copied from MatrixScan Find and kept some of its wording, and on .NET iOS some of its API.
BarcodePickView.PrepareSearching()andStopSearching(), which areBarcodeFindViewmethods. The .NETBarcodePickViewAPI reference (iOS, Android) hasStart()andStop()instead. The public .NET Pick samples (iOS, MAUI) call those. The snippets and the prose now useStart()/Stop(). The MAUI finish-button text on .NET Android saidStopSearchingtoo.PickBarcodePageeverywhere. It wasMyFindBarcodePagein one snippet andFindBarcodePagein another, so the snippets didn't fit together. Also "If your are" is now "If you are".Current docs only. The 7.6.15 and 6.28.11 copies are unchanged: I could only check the API reference for the current SDK.
Questions for the product owner (not changed here)
FinishButtonTapped. Is the sentence out of date?Stop()and thenOnPause()inOnDisappearing; the MAUI sample calls onlyStop()there. Is the extraOnPause()intended?Test plan
viewWillDisappearlink renders.PrepareSearching,StopSearching, "find session" orFindBarcodePageleft in any Pick guide.Follows #491, which fixed "MatrixScan Find supports…" in the Pick intro.
🤖 Generated with Claude Code