Repository navigation
docs(scient): definition of done and review line in the PR template - #70
Merged
Merged
Conversation
yaacovcorcos
force-pushed
the
claude/work-rules-20261117
branch
2 times, most recently
from
November 17, 2026 11:53
84b711b to
a8a07a0
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…done Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yaacovcorcos
force-pushed
the
claude/work-rules-20261117
branch
from
November 17, 2026 13:54
a8a07a0 to
2d881f3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A short Definition of done for Scient Agent, written into Scient's own file (
SCIENT.md), following this repository's rule to keep Scient's changes apart:bun check, the focused tests and the Scient checks the change touches pass;gh pr checksshows every job green,CI passedincluded, whichmainrequires since ci: require one passing check on main; let Dependabot update only Scient's actions #69. An unrelated failed job is rerun once, then reported.Two small marked
scient(SA-POLICY)hooks in Oh My Pi files: one sentence in the existing AGENTS.md block pointing at the new section, and two fields (Platforms, Review) in the PR template. The SA-POLICY ledger contract now mentions the definition of done.Why
The same rules are being added to Scient Desktop (ScientFactory/scient-desktop#977). Agent work was reported finished without platform notes, review records or link checks, and merges need an explicit "green before merge" step.
Testing
bun scripts/scient/divergence-check.ts --footprint: every divergence accounted for. SA-POLICY grows by one AGENTS.md sentence and a 10-line template block; the template needs a place for the PR to record platforms and review.git diff --checkclean. Docs only: no code, build or test change.Platforms
Docs and template only, so behavior is the same on macOS, Linux and Windows; nothing to run per platform.
Review
Review: Claude Fable 5.2 (high) and Codex gpt-6.1-sol (high), independent and read-only: 26 findings across both repos, 24 accepted. One recheck by both: 9 findings, all accepted.
bun checkpasses (no TypeScript or Rust changed; divergence check run)Merge order: merge ScientFactory/scient-desktop#977 first. The UI-checklist link in
SCIENT.mdpoints at a section that PR adds.Model/harness: Claude Opus 5.5 / Claude Code (Scient).
🤖 Generated with Claude Code