Skip to content

fix(scient): name Scient Agent to GitHub and correct the 19.0.1 receipt - #78

Merged
yaacovcorcos merged 2 commits into
mainfrom
claude/omp19-review-fixes-20261120
Nov 20, 2026
Merged

yaacovcorcos merged 2 commits into
mainfrom
claude/omp19-review-fixes-20261120

Conversation

@yaacovcorcos

@yaacovcorcos yaacovcorcos commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #77, from a Codex review of the changes made after its last recheck.

  • User-Agent leak. The Git view's GitHub avatar lookup sent omp as its User-Agent, a leak since before this alignment. The identity generator now renames it to scient-agent. The rename itself is a separate Scient-Generator: identity commit, so the divergence check regenerates it.
  • Receipt corrections in SCIENT.md, "Twelfth alignment intake":
    • The RPC changes were not additions only: handoff now answers with empty data, without savedPath. Desktop never sends it. bash.excludeFromContext already shipped in 0.1.13, so it is no longer listed.
    • Desktop drops inherited SCIENT_AGENT_* variables but sets SCIENT_AGENT_HOST_PAGES and SCIENT_AGENT_ENABLE_SOURCES besides the root.
    • The review line now records this third review.
  • Release step 1 said a blank run or 0.2.0 would work. The new check refuses both for the first Oh My Pi 19 release, which is -f version=1.0.0.

Not taken, with reasons in the receipt:

  • A failure signature on each known failure. Each entry is already pinned to the exact upstream commit and was seen failing on untouched upstream. A signature drawn from one to three observed failures would fail a run on the next flake that ends at another assertion.
  • A narrower signature for the relay quarantine. The relay tests that re-adopt a detached tab are not quarantined and take the same reattach path, so a broken reattach would still fail CI. Release runs ignore the quarantine.

Checks on macOS arm64:

  • Identity and wording --check pass.
  • The script tests pass (88), as do git-tui-sidebar.test.ts and check:ts.

The User-Agent change is the same on every platform.

🤖 Generated with Claude Code

yaacovcorcos and others added 2 commits November 20, 2026 10:47
The Git view's GitHub avatar lookup sent `omp` as its User-Agent; the
identity generator now names Scient Agent there (the next commit applies it).

The twelfth intake's receipt said the RPC changes were additions only,
but `handoff` no longer returns `savedPath`, and `bash.excludeFromContext`
shipped in 0.1.13. It also said Desktop passes no Scient Agent variable
but the root; it sets its page and source switches too. Release step 1
gave a blank run and 0.2.0 as examples, which the new check refuses for
the first Oh My Pi 19 release: it is 1.0.0.

Found by a Codex review of the changes made after its last recheck.

Scient-Divergence: GEN-IDENTITY
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scient-Generator: identity
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos
yaacovcorcos force-pushed the claude/omp19-review-fixes-20261120 branch from 1bc9095 to c38510d Compare November 20, 2026 08:48
@yaacovcorcos
yaacovcorcos merged commit 3240e42 into main Nov 20, 2026
22 checks passed
@yaacovcorcos
yaacovcorcos deleted the claude/omp19-review-fixes-20261120 branch November 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant