Skip to content

chore(upstream): merge t3 through 15d945faef - #1065

Merged
yaacovcorcos merged 91 commits into
mainfrom
codex/t3-sync-c1464d6774-20261122
Nov 22, 2026
Merged

yaacovcorcos merged 91 commits into
mainfrom
codex/t3-sync-c1464d6774-20261122

Conversation

@yaacovcorcos

Copy link
Copy Markdown
Contributor

Nightly T3 alignment: one literal merge of the 87 official pingdotgg/t3code commits after c1464d6774 through 15d945faef. Receipt: docs/internals/t3-upstream-sync-20261122-c1464d6774.md.

What changes for users

  • Slash commands typed during a turn wait in the queue instead of steering it.
  • Dictation finished after switching threads is sent to its own thread.
  • Cleaner text from RTF, ODT, Word and PowerPoint attachments; CSV preview keeps row heights; clipped Files tree names show on hover.
  • Fewer Git reads in branch pickers, push, pull, commit and turn end.
  • Hidden features turn on through one T3CODE_FEATURE_FLAGS list.

Scient composition worth reviewing

  • GitHub sign-in: T3 moved the app client ID into feature flags; Scient for GitHub stays the default through T3's flag service (ScientGitHubApp.ts). Without this, Scient's GitHub sign-in would have switched off silently.
  • Dictation detached send: Scient's send is a stable callback, so the hook hands out the render's own send (sendFromRender), and Scient's "left this thread" check accepts a detached send whose stored draft is unchanged.
  • Secrets stays hidden (T3's secret_providers flag defaults off); the sidebar composes it with Scient's desktop-only Voice entry.
  • T3's PDF viewer stays removed (Scient's PDF.js reader already opens links).
  • Scient's receipt timestamp formatter is renamed formatReceiptDateTime beside T3's formatDateTimeTimestamp.

Agent context

MCP tool list +26 bytes, from T3's new scope parameter on create_issue (label agent-context-increase).

Platforms

macOS: verified locally (static checks, full test gate with the fixes, build, desktop smoke, live test). Windows and Linux: hosted CI only. T3's Windows changes (PATH listing cache, non-ASCII PATH probe, launcher outside PATH) and the Linux AppImage systemd stop are covered by their tests but were not run on those systems locally.

Verification, Codex review and live-test record follow in comments.

🤖 Generated with Claude Code

turnercore and others added 30 commits November 21, 2026 04:16
…#40271)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ng (#40316)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…the thread a second time (#40311)

Co-authored-by: Orin <orin@orin.ws>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…0360)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… (#40381)

Co-authored-by: Abaan <abaan@Abaans-MacBook-Pro.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… update fails (#37225)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Adamulek123 and others added 17 commits November 21, 2026 14:56
…ks (#40592)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…595)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… (#40604)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
… is gone (#40627)

Co-authored-by: Kevin Flores <101906409+kevincommits@users.noreply.github.com>
… drag (#33221)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…itle limit (#29830)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…ests (#40634)

Co-authored-by: Mostafa El Ayoubi <20224923+MostafaElAyoubi@users.noreply.github.com>
…n (#40633)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Literal merge of the 87 official pingdotgg/t3code commits after
c1464d6 through 15d945f, composed with
Scient's seams. Composition notes are in the alignment receipt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…issue APIs

- Mocks gain T3's new methods: capturesSoFar, readLocalStatusRefSnapshot,
  linkMetadata.
- The status refresh result carries T3's refsDigest; the non-repository Git
  sequence includes T3's batched layout read.
- The snapshot shedding test reads locators from the ARIA tree, since T3
  dropped interactiveElements.
- T3's Windows launcher test expects Scient's Node launcher.
- The Office test counts file reads only; T3's table preview now reads
  client settings, which reaches the environment.
- An empty github_app_client_id reads as unset in T3's flags, so that case
  and its doc line go.
- MCP tool list budget +26 bytes from T3's create_issue scope parameter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos yaacovcorcos added the agent-context-increase Accept a larger agent context (Agent Context Budget check) label Nov 22, 2026
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 22, 2026
@github-actions

github-actions Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

This PR changes the test suite by +86 test cases (browser +18, unit +29, server +39).

New browser test files: apps/web/src/browserHistoryStore.browser.test.ts, apps/web/src/lib/imageCompression.browser.test.ts, apps/web/src/lib/selectionActions.browser.test.ts.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

… paths

From the Codex review of the alignment:
- A dictation sent after its thread left the screen keeps a Goal or Plan
  chip's command, and in a thread with people in it stays in the draft
  instead of reaching the agent.
- T3's strict parser for recorded Windows launchers also recognizes the
  Node-backed shim Scient's update writes, so the next update finds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos

Copy link
Copy Markdown
Contributor Author

Verification (head 0e43f6850eb)

Local, macOS arm64, Node 26.13.1, synthetic state

  • format, lint, knip, root typecheck (63 packages), i18n, brand, seam check, upstream provenance: pass.
  • Full test gate: the first run's merge fallout is fixed in 0ed6160b21a (mocks and expectations for T3's new APIs). Each failing server test was compared with main in a baseline worktree. What remains fails on main too or only on this Mac: theme-watcher symlink test (also fails alone on main), ChatMarkdown.permissions native-menu cases, PortScanner, ProjectSetupScriptRunner, ClaudeSkills, LatexRealEngine. The desktop and GitHubRest failures came from the long temp path; both packages pass with a short one.
  • Build and desktop smoke: pass.

Codex review (gpt-6.1-sol, high), two rounds
Three should-fix findings, all fixed in 0e43f6850eb and confirmed resolved on recheck:

  1. A detached dictation in a thread with people in it bypassed room routing. It now stays in that thread's draft.
  2. A detached dictation dropped the Goal/Plan chip. The command is now applied.
  3. T3's strict parser for recorded Windows launchers didn't recognize Scient's Node-backed shim. It does now, with a test.
    No blockers. Nothing redundant or T3-branded left.

Live test (clean dev app at the head, real Haiku): Settings sidebar (Secrets hidden, Voice present), Scient for GitHub sign-in offered, clipped Files names show a tooltip, wide CSV keeps row heights while scrolling sideways, and /compact steered into a busy turn is queued rather than steering. Record with screenshots: ScientFactory/reviews/t3-sync-15d9-20261122/RECORD.md (local).

Platforms: macOS verified locally. Windows and Linux rely on hosted CI; T3's Windows PATH-cache, launcher and PowerShell changes and the AppImage systemd stop were not run natively here.

@yaacovcorcos
yaacovcorcos marked this pull request as ready for review November 22, 2026 03:39
@yaacovcorcos
yaacovcorcos added this pull request to the merge queue Nov 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 22.3 KiB 22.3 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 22.7 KiB 22.7 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 12.0 KiB 12.0 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 45.5 KiB 45.5 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 45.5 KiB 45.5 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 12.2 KiB 12.2 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.1 KiB 384.1 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 46.1 KiB 46.1 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 46.1 KiB 46.1 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: f1bfa56 · PR result: 0e43f68 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Bounded compact HTTP snapshot with live cursor.

  • Codex decoded thread snapshot: 88.2 KiB
  • Claude decoded thread snapshot: 88.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Merged via the queue into main with commit 55dd9fa Nov 22, 2026
85 checks passed
@yaacovcorcos
yaacovcorcos deleted the codex/t3-sync-c1464d6774-20261122 branch November 22, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-context-increase Accept a larger agent context (Agent Context Budget check) size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.