Skip to content

feat(desktop): read Stable and Beta updates from verified mirror feeds - #967

Merged
yaacovcorcos merged 10 commits into
mainfrom
claude/desktop-mirror-feed-20261116
Nov 17, 2026
Merged

yaacovcorcos merged 10 commits into
mainfrom
claude/desktop-mirror-feed-20261116

Conversation

@yaacovcorcos

@yaacovcorcos yaacovcorcos commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Stable and Beta apps now check Scient's verified mirror feed (downloads.scientfactory.com/scient-desktop/updates/{stable,beta}) for updates instead of GitHub. Nightly still uses GitHub, administrator overrides still take precedence, and Windows publisher verification and build-time publishing metadata are unchanged. Differential downloads use single-range requests.

Outcome attribution follows the feed and channel actually used. Apply outcomes omit the previous process's source, which is no longer available; attemptRef links back to the original handoff.

GitHub fallback

The owner asked for a GitHub fallback as well as the mirror, so an app that can't reach the mirror can still update:

  • Check: if the mirror check fails, the same check runs again against GitHub. When neither answers, only GitHub's error is reported.
  • Download: if a download from the mirror fails, the app uses GitHub for the rest of that run. electron-updater downloads from the provider its last check used, so the background retry re-checks GitHub before it downloads (refreshFromGitHub). Without that, the retry would go back to the mirror.
  • The fallback only applies to channels whose runtime feed is the mirror (generic provider). Nightly and administrator-set feeds are left alone.

Mirror is live

Website #77 is merged, and the scientfactory-release-mirror worker was deployed from website main on 2026-11-17. Its cron runs have populated both feeds:

  • Stable: 0.6.29
  • Beta: 0.6.30-beta.20261115.2

Every *.yml manifest (mac, Windows, Linux) and every file they list returns 200.

Stack

Built on #970. Once #970 merged, this was retargeted to main and main was merged in with a merge commit.

Verification and review

  • After the main merge (9396528c86c): root pnpm run typecheck, vp check (0 errors), the seam check against origin/main, upstream provenance, and the desktop update tests (src/updates and src/scient/updateOutcomes, 11 files, 146/146). All were run on macOS with Node 26.13.1.
  • Four fallback tests are in DesktopUpdates.scient.test.ts. The background-retry test fails without the refreshFromGitHub fix.
  • Independent Codex reviews covered the feed patch, the fallback and this realign. Two real findings, both fixed with tests that fail without the fix:
    • The background retry downloaded from the provider electron-updater had cached.
    • After a failed GitHub re-check, later retries stopped asking GitHub. The owed check now clears only when GitHub answers (779646df169).
  • Final tree (1520d6534ff, on main 9b6059bcb79): seam, provenance, typecheck and the update tests (147/147) pass. The diff against main is the 8 feed files only.

Platforms

  • Feed selection and fallback logic are shared code for macOS, Windows and Linux.
  • Tested locally on macOS only (unit tests); CI runs the cross-platform lanes.
  • Not proven on a real install on any platform: discovering and downloading an update from the mirror in a signed app, including the macOS apply step, Windows NSIS publisher and SmartScreen checks, and Linux AppImage/deb. If the mirror misbehaves on one of these, the GitHub fallback keeps updates working.

Documentation impact

Updated the existing managed-policy documentation and the fork seam note in UPSTREAM.md, which now mentions the fallback. No UI change.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M labels Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 22.3 KiB 22.3 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 22.7 KiB 22.7 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 12.0 KiB 12.0 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 45.5 KiB 45.5 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 45.5 KiB 45.5 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 12.2 KiB 12.2 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.1 KiB 384.1 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 46.1 KiB 46.1 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 46.1 KiB 46.1 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: 9b6059b · PR result: 1520d65 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Bounded compact HTTP snapshot with live cursor.

  • Codex decoded thread snapshot: 88.2 KiB
  • Claude decoded thread snapshot: 88.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yaacovcorcos
yaacovcorcos changed the base branch from main to claude/downloads-updates-20261116 November 16, 2026 22:16
@yaacovcorcos
yaacovcorcos force-pushed the claude/desktop-mirror-feed-20261116 branch 2 times, most recently from fa67901 to 221cdec Compare November 16, 2026 22:34
yaacovcorcos and others added 2 commits November 17, 2026 00:42
Running apps now check ScientFactory's generic electron-updater feeds instead of
the GitHub release indexes:

- Stable: https://downloads.scientfactory.com/scient-desktop/updates/stable
- Beta:   https://downloads.scientfactory.com/scient-desktop/updates/beta

The website's release mirror publishes these only after every file they name is
in its immutable version directory. Nightly keeps GitHub, which the mirror does
not carry. Like GitHub's provider, the feed downloads differences with single
range requests.

Unchanged: an administrator's policy feedUrl still wins on every channel; the
app-update.yml baked at build time still names GitHub (publisher compatibility for
older clients and the build's publish config); Windows publisher verification
still reads publisherName from that installed app-update.yml, so signature checks
do not depend on the feed.

Do not merge until the mirror feeds are deployed, populated and verified
(ScientFactory-website release-mirror runbook): before then every check would
fail with a missing channel file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos
yaacovcorcos force-pushed the claude/desktop-mirror-feed-20261116 branch from 221cdec to 3726dbc Compare November 16, 2026 22:42
yaacovcorcos and others added 4 commits November 17, 2026 09:16
… serve

A check the mirror cannot answer runs again against GitHub in the same
check; a download the mirror fails leaves the rest of the run on GitHub.
Every release is on GitHub, so an app never strands on a missing or
broken mirror feed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed-20261116

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… UPSTREAM.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added size:L and removed size:M labels Nov 17, 2026
yaacovcorcos and others added 3 commits November 17, 2026 09:25
…hed mirror

electron-updater downloads from the provider its last check used, so the
background retry after a mirror download failure first checks GitHub.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… download fails

A failed GitHub check left electron-updater downloading from the mirror,
but the retry guard read the feed already selected and stopped re-checking.
Track the owed GitHub check separately and clear it only when GitHub answers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from claude/downloads-updates-20261116 to main November 17, 2026 09:08
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos
yaacovcorcos marked this pull request as ready for review November 17, 2026 11:51
@yaacovcorcos
yaacovcorcos added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit f4293ac Nov 17, 2026
80 of 82 checks passed
@yaacovcorcos
yaacovcorcos deleted the claude/desktop-mirror-feed-20261116 branch November 17, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant