Fix Ethernet regression and add support links/Zenodo - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ethernet regression
The v1.0.0 TCP transport terminated SCPI commands with CR only. Druck K0472 section 2.2 requires LF (ASCII 10), while the validated v0.3.1 Windows implementation sends CRLF. The PACE could therefore keep waiting for the end of
*IDN?until the application timed out.Help and acknowledgements
https://github.com/SebRoLENS/pace-controller/issues.romi@lens.unifi.itin the application.Zenodo DOI automation
CITATION.cff, and GitHub release notes.Validation
17 passedin the cross-platform pytest suite.git diff --checkpasses.Hardware validation should begin at low pressure on an unloaded setup. Zenodo archival additionally requires enabling this repository once in the user's Zenodo GitHub integration.