Fix Windows unreachable-network error for PACE Ethernet - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The cross-platform Python client assigned
192.168.10.1/24to the dedicated adapter but retried immediately without reproducing the remaining network setup used by the validated Windows controller. On a PC with several active adapters this can leave Windows without a usable route to192.168.10.2, producing[WinError 10051]before any SCPI command is sent.Fix
192.168.10.1asPreferred;192.168.10.0/24on the selected adapter;192.168.10.1;TCP_NODELAY, matching the legacy implementation;192.168.10.0/24on another physical adapter.Validation
169.254.233.163/16and no gateway;192.168.10.1andTCP_NODELAY;19 passedin the cross-platform pytest suite;git diff --checkpasses.The frozen PowerShell implementation remains unchanged.