fix: send client_id on the token request when no auth method is set - #161
Merged
Merged
Conversation
ikawalec
marked this pull request as ready for review
September 10, 2026 07:03
holowinski
self-requested a review
September 23, 2026 16:21
holowinski
approved these changes
Sep 23, 2026
ikawalec
enabled auto-merge
September 23, 2026 16:22
…ent-id # Conflicts: # internal/oauth2/request_test.go
jdabrowski
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
Device flow leaves
AuthMethodempty (PromptForClientConfigonly asks for it on the code/client_credentials/refresh/password/jwt-bearer grants), andAuthenticateClientswitches onAuthMethod— so with no auth method the token request carried onlygrant_typeanddevice_code, and the server answeredinvalid_client.Fixing it in
AuthenticateClientcovers every caller (token, PAR), not just device flow.Before:
After: