Refresh the DSv4 MI355X SGLang AgentX arm to v0.5.18 and split TP4/TP8 by concurrency - #2713
Conversation
…rency Image: lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260813 -> lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260822. Serving flags: - enable SGLANG_OPT_USE_AITER_BATCHED_GEMM=1, the aiter batched GEMM for the absorbed MLA projections, which defaults off in environ.py - mem-fraction-static 0.85 -> 0.89 to enlarge the full-attention KV pool. The DSv4 compressor state pools are sized from that pool and allocated after it, outside this budget, so the remainder still has to cover them, which is why this stops short of 0.90. - --disable-shared-experts-fusion -> --enforce-shared-experts-fusion. The tuned MoE tables in this image cover the resulting (inter_dim 384, expert 385, topk 7) shape at the token sizes this workload hits. Search space, split by concurrency so the arms stop overlapping: - add TP4 at [1, 2, 4, 8, 10] with no host KV tier, where halving the GPUs per replica raises throughput per GPU - reduce the TP8 no-offload arm from [1, 2, 4, 8, 16] to [16] - net effect on published data: drops TP8 conc 1, 2, 4, 8 and adds TP4 conc 1, 2, 4, 8, 10; the hicache arm is unchanged at [16, 32, 48], and conc 16 still appears on both TP8 arms to isolate the host KV tier's gain TP4 doubles per-rank weights and leaves far less room for KV, which is why it stops at concurrency 10 and ships no hicache variant. runner (cluster:mi355x-amds) is unchanged and no directory structure changed. Also rewords the key's comment: "pure TP8 only" becomes "tensor-parallel only", which is what it meant, since the exclusion is DP-attention rather than TP4. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
1 similar comment
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
Co-authored-by: Cursor <cursoragent@cursor.com>
main added the glm5.1 TileRT AgentX entry (#2650) at the end of the changelog while this branch appended the DSv4 MI355X entry, so the two collided on the same trailing lines. Both are kept, upstream's first. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=32688409514 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f49b272. Configure here.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=32724927772 |
|
/reuse-sweep-run 32724927772 |
1am9trash
left a comment
There was a problem hiding this comment.
As a PR reviewer and CODEOWNER, I have reviewed this and have:
- Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
- Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
- Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this. Link: https://inferencex.semianalysis.com/inference?unofficialRun=32724927772
- Verified that this PR passes evals. Please link to GitHub Action workflow that shows this. Link: https://inferencex.semianalysis.com/evaluation?unofficialRun=32724927772
- Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
- For agentic workloads: verified that speculative-decoding configs (EAGLE / MTP / draft models) run with simulated synthetic acceptance, with the acceptance-length value taken from the committed golden AL curve in golden_al_distribution/ for that model, thinking mode, and draft length. A submission may choose any supported draft length, but it may not substitute a different acceptance target.
- Verified against the current MODELS.md that this PR does not submit a deprecated model, scenario, or model-scenario combination.
- Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
- If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
- If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
- Verified that every single-node vLLM/SGLang recipe in this PR is documented in the official vLLM recipes and/or the SGLang cookbook:
- I linked the corresponding upstream PR in the vLLM recipe repo or SGLang repo and verified that it is MERGED before this InferenceX PR merges. An opened, draft, or closed-without-merge upstream PR does not satisfy this requirement. If the matching recipe was already published, I linked the published recipe/cookbook page in the additional detail section below.
- Verified that this PR does not patch the inference engine or serving stack — the pinned image must run as shipped. This covers .patch files / git apply / patch, inline patches embedded in benchmark scripts (e.g. a python3/sed heredoc that rewrites installed engine sources before serving), in-place edits of site-packages, monkey-patching, overwriting container files, and installing forked/rebuilt engine wheels on top of the pinned image. The only exception is a patch covered by a filled-out waiver at docs/waiver/
<PR_NUMBER>.md— named after the PR that introduces the patch and filed in that same PR, stating what is patched, why the unmodified upstream image cannot run this benchmark, the upstream PR/issue link, and the removal plan — which I have linked below in the additional detail section. - If this PR uses
append-only: true, verified that it only adds generated points or recipe variants inside a selected existing config/scenario and existing same-image visual curve: every previously generated point remains present with the same recipe, no prior point is removed or rerun, and every benchmark-affecting change in the complete diff can affect only the corresponding newly appended points (never an existing point), regardless of which file contains it. - If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.
Additional detail section:
Signed: @1am9trash
✅✅✅ Verdict: PASS ✅✅✅✅ Check 0 (CODEOWNER): PASS — |
|
Hi, @functionstackx |
|
@1am9trash plz ping @cquil11 or @adibarra for review plz |
|
/stage-results 32724927772 |
|
@cquil11 staged run 32724927772: https://inferencemax-app-git-staging-semianalysisai.vercel.app/inference?i_dates=2026-08-24~r32724927772 This run remains available across future |

Summary
Refreshes
dsv4-fp4-mi355x-sglang-agentic-mtponto the v0.5.18 MI355X image with the serving flags validated on the AMD side, and splits the search space so TP4 covers the low-concurrency end instead of TP8 duplicating it.Replaces #2710, which was opened from a fork.
Image and serving flags
lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260813→lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260822SGLANG_OPT_USE_AITER_BATCHED_GEMM=1, the aiter batched GEMM for the absorbed MLA projections, which defaults off inenviron.pymem-fraction-static0.85 → 0.89, enlarging the full-attention KV pool. The DSv4 compressor state pools are sized from that pool and allocated after it, outside this budget, so the remainder still has to cover them — which is why this stops short of 0.90.--disable-shared-experts-fusion→--enforce-shared-experts-fusion. The tuned MoE tables in this image cover the resulting(inter_dim 384, expert 385, topk 7)shape at the token sizes this workload hits.Search space
[1, 2, 4, 8, 10]with no host KV tier, where halving the GPUs per replica raises throughput per GPU[1, 2, 4, 8, 16]to[16], so TP8 picks up where TP4 leaves off[16, 32, 48], and concurrency 16 still appears on both TP8 arms to isolate the host KV tier's gain.TP4 doubles per-rank weights and leaves far less room for KV, which is why it stops at concurrency 10 and ships no hicache variant.
runner(cluster:mi355x-amds) is unchanged and no directory structure changed. The key's comment is also corrected: it no longer claims the image matches the disagg AgentX entry (that key is still onv0.5.17-...-20260817), and "pure TP8 only" becomes "tensor-parallel only", which is what it meant — the exclusion is DP-attention, not TP4.Test plan
bash -n benchmarks/single_node/agentic/dsv4_fp4_mi355x_sglang_mtp.shconfigs/amd-master.yamlandperf-changelog.yamlboth parseprocess_changelog.py --base-ref main --head-ref HEADtriggers all 9 cells plus the conc-48 agentic evalMade with Cursor