Skip to content

Handle Incomplete TCP Frame Transmit - #15

Merged
psachs merged 5 commits into
masterfrom
tcp-handle-incomplete-send-frame
Sep 22, 2026
Merged

Handle Incomplete TCP Frame Transmit#15
psachs merged 5 commits into
masterfrom
tcp-handle-incomplete-send-frame

Conversation

@lsigrist

@lsigrist lsigrist commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add detection and handling of only partially sent SHDLC frames via TCP:

  • use socket.sendall() instead of socket.send() for TCP frame transmission to detect partial send errors
  • add fake test TCP transmit test to reproduce

Alternatives considered:

  • Add dedicated error for transmit errors: rejected due to no relevance for existing stacks on top

Fixes: #14

@lsigrist lsigrist self-assigned this Sep 10, 2026
@lsigrist
lsigrist force-pushed the tcp-handle-incomplete-send-frame branch from 9d4d13a to 11a5e7a Compare September 10, 2026 11:37
@lsigrist
lsigrist force-pushed the tcp-handle-incomplete-send-frame branch from 11a5e7a to 5907513 Compare September 10, 2026 11:44
dstraessler
dstraessler reviewed Sep 11, 2026
View reviewed changes
Comment thread sensirion_shdlc_driver/port.py
@psachs
psachs merged commit 5b9aa2d into master Sep 22, 2026
13 checks passed
@psachs
psachs deleted the tcp-handle-incomplete-send-frame branch September 22, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psachs psachs psachs approved these changes
@dstraessler dstraessler dstraessler approved these changes

Assignees

@lsigrist lsigrist

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Silent Frame Truncation on Partial TCP Send

3 participants

@lsigrist @psachs @dstraessler