Conversation
contracts-1.3.9.test.mjs resolved the hyperautomation SKILL.md relative to its own location as mcp/hyperautomation/SKILL.md, a directory that has never existed in this repo. The real file lives at plugins/s1-secops-skills/skills/hyperautomation/SKILL.md. Both tests that read it failed with ENOENT on a plain npm test since the test was added in 1.3.9, and no CI workflow runs the mcp test suite so it went unnoticed. Corrects the relative path and adds a regression test pinning it so a future restructure of either directory fails loudly here instead of silently reintroducing the ENOENT.
pmoses-s1
added a commit
to pmoses-s1/ai-siem
that referenced
this pull request
Oct 2, 2026
… layout (supersedes Sentinel-One#100)
Author
|
Upstream commit 40ff0bb supersedes this fix. Its resolver supports both repository layouts and adds an existence regression. I ran The current conflicts overlap that resolver and the test script. I have left this branch unchanged to preserve the broader upstream fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
contracts-1.3.9.test.mjsresolves the hyperautomationSKILL.mdrelativeto its own file location:
That resolves to
mcp/hyperautomation/SKILL.md, a directory that does notexist anywhere in this repo. The real file is at
plugins/s1-secops-skills/skills/hyperautomation/SKILL.md.Impact
Running the documented dev workflow (
npm testinsidemcp/s1-secops-mcp,per the README) fails two tests with ENOENT:
This has been broken since the test was added for 1.3.9. No workflow in
.github/workflowsruns the mcp test suite (only TruffleHog + release), sonothing has caught it in CI; it only surfaces to a contributor who runs
npm testlocally.Fix
Corrected the relative path to point at the real location of
SKILL.md,three directories up from the tests folder into
plugins/s1-secops-skills/skills/hyperautomation/.Also added
tests/regressions-2026-09-25.test.mjs, following this repo'sexisting dated-regression-test convention, which pins that the resolved path
exists and still contains the smoke-test section the contract tests parse.
Wired it into the
testscript inpackage.json.Test plan
npm testinmcp/s1-secops-mcp: 130 pass / 2 fail before this change,134 pass / 0 fail after (132 existing + 2 new).
gone with the fix by stashing the change and re-running.
AI was used for drafting/refactoring. Tool: Claude Code.