You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ogg: Don't drop audio when the setup header ends mid-page - #730
This solves #729 : silent complete data loss when modifying an OGG file whose last header packet (setup header) ends mid-page (experienced in currant prior to trougnouf/currant@7b61784 )
This fix rewrites the writer at page granularity rather than packet granularity.
Hi @Serial-ATA ,
I don't mean to be pushy but I'm surprised by your lack of response here. You are aware that this bug causes complete loss of any affected OGG file touched by your library, right? This is obviously unacceptable and the worst thing a metadata-handling library could possibly do.
Yes, I'm no stranger to corruption bugs. I understand the severity of the issue and it'll definitely be fixed in 0.25.5. Until then I recommend you just depend on your fork.
Please do recognize that I'm the only person maintaining this project. I only look into issues when time and motivation both permit.
Yes I understand. It's been 2 weeks without a response and I noticed some activity so I thought it may have fallen through. Glad you are on it and thanks for your work.
On my end I just went with not trusting the metadata writer and checking the resulting file s.t. it can't happen again in currant, it's worth the latency.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #729 : silent complete data loss when modifying an OGG file whose last header packet (setup header) ends mid-page (experienced in currant prior to trougnouf/currant@7b61784 )
This fix rewrites the writer at page granularity rather than packet granularity.
Verified against the reproduction from #729
Developed with AI assistance (Qwen 3.8 Q4)