Skip to content

Ogg: Don't drop audio when the setup header ends mid-page - #730

Open
trougnouf wants to merge 3 commits into
Serial-ATA:mainfrom
trougnouf:fix/ogg-audio-loss
Open

trougnouf wants to merge 3 commits into
Serial-ATA:mainfrom
trougnouf:fix/ogg-audio-loss

Conversation

@trougnouf

@trougnouf trougnouf commented Sep 23, 2026 •

Copy link
Copy Markdown

This solves #729 : silent complete data loss when modifying an OGG file whose last header packet (setup header) ends mid-page (experienced in currant prior to trougnouf/currant@7b61784 )

This fix rewrites the writer at page granularity rather than packet granularity.

Verified against the reproduction from #729

Developed with AI assistance (Qwen 3.8 Q4)

@trougnouf

trougnouf commented Oct 8, 2026 •

Copy link
Copy Markdown
Author

Hi @Serial-ATA ,
I don't mean to be pushy but I'm surprised by your lack of response here. You are aware that this bug causes complete loss of any affected OGG file touched by your library, right? This is obviously unacceptable and the worst thing a metadata-handling library could possibly do.

@Serial-ATA

Copy link
Copy Markdown
Owner

Yes, I'm no stranger to corruption bugs. I understand the severity of the issue and it'll definitely be fixed in 0.25.5. Until then I recommend you just depend on your fork.

Please do recognize that I'm the only person maintaining this project. I only look into issues when time and motivation both permit.

@trougnouf

trougnouf commented Oct 8, 2026 •

Copy link
Copy Markdown
Author

Yes I understand. It's been 2 weeks without a response and I noticed some activity so I thought it may have fallen through. Glad you are on it and thanks for your work.
On my end I just went with not trusting the metadata writer and checking the resulting file s.t. it can't happen again in currant, it's worth the latency.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants