Repository navigation
AIFF: Skip the padding of odd-sized COMT comments - #737
Merged
Merged
Conversation
Every comment following an odd-sized one was read one byte early, either returning garbage or failing to read the entire file.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks, I threw in an extra guard for non-zero padding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #736
The pad of the final comment is still left to
Chunks::skip(), so a file missing that pad keeps reading as it does today instead of failing at the end of the chunk.Tests:
aiff_text_re_read_odd_sized_comments: round trip throughdump_to, with odd-sized comments that aren't lastparse_padded_comments: hand-built bytes in the spec layout, not written by loftyparse_unpadded_final_comment: a final comment without its pad still parsesAI Disclosure: the tests were written with Claude Code. I reviewed and ran them myself.