Repository navigation
Conversation
…the system's ANSI code page reaches fopen, CreateFileA and FindFirstFileA intact
timoncool
added a commit
to timoncool/YuE2-Studio
that referenced
this pull request
Oct 26, 2026
…ge, so paths outside the system's ANSI code page open (ServeurpersoCom/yue2.cpp#22); the writing assistant's model downloads through the HF-Mirror when the settings take models from it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the tools open files through the narrow APIs (
fopen,CreateFileA,FindFirstFileA), which take the process's ANSI code page. A path with characters outside that code page - Chinese on a Russian or English Windows, Cyrillic on an English one - reaches them as?and the file is not found.This embeds an application manifest that sets the process code page to UTF-8 (
activeCodePage, Windows 10 1903 and later) in every executable on MSVC, soargvand the paths built from it stay intact. Nothing changes off Windows or with other compilers.Checked:
mp3-codec -i D:\...\测试_音乐\歌曲.mp3on a Windows with code page 1251 - before:[Audio] Cannot open D:\...\??_??\??.mp3; after: decoded and written to新.wav.