Housekeeping: drop the stale cache, fail on deprecations

[loevgaard]

Fixes #33

Stacked on #55.

Changes

Stale cache. phpunit.xml.dist sets cacheDirectory=".build/phpunit", but a .phpunit.result.cache from before that change was still sitting at the repository root, along with the now-pointless .gitignore entry for it. Both removed.

Deprecations now fail the build. The suite reported three PHP deprecations on PHP 8.4, all from setono/bot-detection-bundle (BotDetector::__construct() parameter $popular and BotDetectorInterface::isBotRequest() parameter $request are implicitly nullable). Because they came from a dependency they could not be fixed here, and while they were in the output a new deprecation from this bundle's own code would have gone unnoticed.

<source restrictDeprecations="true"> limits reporting to deprecations triggered by code under src/, which makes failOnDeprecation="true" safe to turn on, together with failOnNotice and failOnWarning.

Note the attribute name: PHPUnit 11 renames it to ignoreIndirectDeprecations, which PHPUnit 10.5 rejects. The bundle supports PHP 8.1, PHPUnit 11 requires PHP 8.2, so 10.5 has to keep working and restrictDeprecations is the spelling that validates under both. There is a comment in the file warning against running the configuration migration, which would silently rename it.

Still worth doing upstream: giving those two BotDetectorInterface parameters an explicit ?Type, since PHP 9 turns the deprecation into an error. Once released, the constraint here can be bumped and this restriction revisited.

Not included

IDE ignores (.idea/, .vscode/) were in an earlier revision and have been dropped: they belong in a developer's global gitignore rather than in the project.

Note on Codecov

The coverage job uploads to Codecov but nothing consumes the result. That is handled in #56 rather than here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.93%. Comparing base (df977e6) to head (40d816a).

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     81.93%   81.93%           
  Complexity      148      148           
=========================================
  Files            31       31           
  Lines           487      487           
=========================================
  Hits            399      399           
  Misses           88       88           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.