Skip to content

Take TelnetNegotiationCore from 2.12.0 to 4.5.2 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarryCordewener merged 1 commit into from
Oct 26, 2026
+11 −2
Merged

Take TelnetNegotiationCore from 2.12.0 to 4.5.2 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,6 +1626,15 @@ markup (`[bold #rrggbb on #rrggbb]…[/]`, `[[`/`]]` escaping, `[link=url]…[/]
`CurrentPrompt`, which nothing renders — the text is simply gone, silently. Before 2.12.0 that same
fragment was merely glued to the head of the next line, which reads as a cosmetic wrap issue rather
than lost text. Revert both together or neither.
- **The 2.x → 4.x jump compiled with no source change here.** 4.0.0 replaced the interpreter with a
generated state machine (4 KiB batches, returning at MCCP boundaries); 3.0.0 dropped OneOf; 4.1.1
made a second plugin for one protocol throw (EOR, SGA and PacketPatch are three plugins, each
registered once — keep it that way). The two reflective reaches above (`CallbackOnByteAsync`,
`CurrentEncoding`'s internal setter) and `NAWSProtocol`'s subclassability are unchanged. The only
build change was `Microsoft.Extensions.Logging.Abstractions`, which 4.x needs at a newer patch.
What the jump *makes available* and is not yet used: a GMCP `Core` client session
(`UseGmcpClientSession`, `TelnetNegotiationCore.Gmcp`), typed GMCP packages, MSDP over GMCP,
`PuebloProtocol`, and MCP 2.1 (`MudClientProtocol`).
- **Never pin a version that is not on nuget.org, and never work around it with a local feed.** A
pin that only resolves from a local `nuget.config` builds here and fails `NU1101` everywhere else;
if a locally-built nupkg of that version is already in `~/.nuget/packages/`, the real package
Expand Down
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<PackageVersion Include="SharpConsoleUI" Version="2.7.8" />

<!-- Telnet negotiation: TELOPT/NAWS/MTTS/EOR/CHARSET/MSSP/GMCP/MSDP/MCCP/MXP negotiation. -->
<PackageVersion Include="TelnetNegotiationCore" Version="2.12.0" />
<PackageVersion Include="TelnetNegotiationCore" Version="4.5.2" />

<!-- The version, from the git tag (see Directory.Build.props). Build-time only. -->
<PackageVersion Include="MinVer" Version="8.0.0" />
Expand All @@ -33,7 +33,7 @@
<PackageVersion Include="AngleSharp" Version="1.7.1" />

<!-- Logging abstractions (TelnetNegotiationCore takes an ILogger). -->
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.2" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.13" />

<!--
Client diagnostics: Serilog behind Microsoft.Extensions.Logging. Only the Tui's composition root
Expand Down
Loading