Skip to content

Mask arguments for a deleted Task - #1608

Open
arthurmde wants to merge 1 commit into
Shopify:mainfrom
arthurmde:deleted-task-argument-filter
Open

arthurmde wants to merge 1 commit into
Shopify:mainfrom
arthurmde:deleted-task-argument-filter

Conversation

@arthurmde

@arthurmde arthurmde commented Nov 19, 2026 •

Copy link
Copy Markdown

Opening a deleted Task that still has runs hides that history. Run#argument_filter loads the Task class to collect mask_attribute names, and Task::NotFoundError is turned into the not-found page. The other Run methods that look up the class already rescue that error.

When the class is gone, mask the stored arguments with the application's filter_parameters only. A Task that still exists keeps its own masks.

Release notes

Rendering a deleted Task's previous runs no longer fails when those runs stored arguments. Sensitive keys from filter_parameters stay masked. mask_attribute still applies when the Task class exists.

argument_filter loaded the Task class to collect mask_attribute names, so a deleted Task with stored arguments could not render its runs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@arthurmde
arthurmde marked this pull request as ready for review November 19, 2026 16:23
@arthurmde

Copy link
Copy Markdown
Author

I have signed the CLA!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant