Use the selected chat model for the Ruby design agent - #4193
Open
Hashim1999164 wants to merge 2 commits into
Open
Use the selected chat model for the Ruby design agent#4193Hashim1999164 wants to merge 2 commits into
Hashim1999164 wants to merge 2 commits into
Conversation
vinistock
reviewed
Aug 21, 2026
Comment on lines
+91
to
+96
| if (!model) { | ||
| [model] = await vscode.lm.selectChatModels({ | ||
| vendor: "copilot", | ||
| family: "gpt-4o", | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
We started out pre-selecting gpt-4o because that was the best one available at the time, but with the explosion of models and offerings I'm not sure it makes a whole lot of sense.
Let's remove this completely and just use whatever the user has selected as their model every time.
Author
There was a problem hiding this comment.
Dropped the gpt-4o fallback. The design agent now uses only the model selected in the chat picker.
| } | ||
| if (!model) { | ||
| stream.markdown( | ||
| "No language model is available for this chat. Select a model in the chat picker and try again.", |
Member
There was a problem hiding this comment.
Suggested change
| "No language model is available for this chat. Select a model in the chat picker and try again.", | |
| "No language model selected. Select a model in the chat picker and try again.", |
Author
There was a problem hiding this comment.
Updated the error string as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4186
Tests