fix(simply-package): match package directory paths across OS separators in dependencies manage - #137
Merged
Conversation
…rs in dependencies manage sfdx-project.json always stores packageDirectories[].path with forward slashes, but SfProject.getPackageDirectories() normalizes that path to the OS separator (backslashes on Windows). applyChanges() compared these with strict equality, so any package directory with a nested path (e.g. force-app/main/default) never matched on Windows, and dependency version updates were silently dropped without any error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ClayChipps
enabled auto-merge
August 28, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependencies manage's directory lookup comparedSfProject.getPackageDirectories()paths (OS-normalized) directly againstsfdx-project.json's raw paths (always forward-slash), causing a false mismatch and silent no-op write on Windows.Test plan
sfdxProjectService.test.tspnpm test🤖 Generated with Claude Code