Repository navigation
Scope cached method results to receiver and function identity - #1544
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached methods on different receivers currently share results when their method names and arguments match. For example, two networks returning degrees 3 and 8 both return 3 when using the same CacheManager. Distinct decorated functions with the same name also collide.
Scope each cache key to the decorated function and receiver identity in addition to the existing argument digest. Identity keys support equal and unhashable receivers and retain the receiver until its entry is evicted or cleared, preventing object-ID reuse. Named cache sizes and invalidation behavior are preserved. Document the receiver lifetime in AGENTS.md.
Validation: